fix: emit TypeQuery type arguments #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@abextm thanks a lot for reporting and providing the fix! Would you be able to add a test for this? Maybe just in https://github.com/dprint/dprint-plugin-typescript/tree/main/tests/specs/issues create another file for issue0426.txt and copy what's done in the other files with a new test case here. That way we can ensure this is actually fixed and doesn't regress in the future. |
abextm
force-pushed
the
fix-typeof-type-args
branch
from
dbb7ec6
to
2879623
Compare
|
Test case added |
dsherret
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
Turns out this was more trivial than I expected it would be