Wrap StackOverflow with JSONException #660
Merged
+1,732
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stleary
changed the title
|
Starting 3 day comment window |
|
@stleary Do you have plans to release a new version with this commit soon? |
|
This is reported as a HIGH vulnerabilitiy by dependencies tools such as JFrog Xray. I would appreciate a release for this fix as well. Thanks a lot |
|
I should be able to get it released this weekend. |
stleary
changed the title
|
Release 20220320 |
erosb
pushed a commit
to hazelcast/hazelcast
that referenced
this pull request
Apr 1, 2022
Xray found a vulnerability on json and was fixed on version 20220320. Please refer to the following links: stleary/JSON-java#654 stleary/JSON-java#660 The new validator library depends on the fixed org.json version: https://github.com/everit-org/json-schema/releases/tag/1.14.1 Source: slack: https://hazelcast.slack.com/archives/G01LH0K3VK8/p1648714007131469
This was referenced Mar 13, 2023
This was referenced Mar 14, 2023
|
这个异常需要怎么解决呢？ |
This was referenced Feb 7, 2023
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654.
This fix is mostly a mitigation in that it wraps a "Stack Overflow" into a "JSON Exception". To properly fix the issue, we would need to refactor the tokener to not be recursive and instead be iterative.
Risks
Low. Exceptions still thrown for invalid data, but StackOverflowError is now wrapped.
Changes to the API?
Will this require a new release?
Yes
Should the documentation be updated?
Possibly.
Does it break the unit tests?
No. New unit tests were added to reflect the issue reported and also to support new validation for JSONObject
Was any code refactored in this commit?
no
Review status
APPROVED