forked from dotnet/roslyn-analyzers
/
DiagnosticAnalyzerAPIUsageAnalyzer.cs
261 lines (231 loc) · 14.4 KB
/
DiagnosticAnalyzerAPIUsageAnalyzer.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.Collections.Immutable;
using System.Linq;
using Microsoft.CodeAnalysis.Diagnostics;
using Analyzer.Utilities;
using Analyzer.Utilities.Extensions;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Threading;
using System.Diagnostics;
using Microsoft.CodeAnalysis.Operations;
using Analyzer.Utilities.PooledObjects;
namespace Microsoft.CodeAnalysis.Analyzers.MetaAnalyzers
{
public abstract class DiagnosticAnalyzerApiUsageAnalyzer<TTypeSyntax> : DiagnosticAnalyzer
where TTypeSyntax : SyntaxNode
{
private static readonly LocalizableString s_localizableTitle = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.DoNotUseTypesFromAssemblyRuleTitle), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
private static readonly LocalizableString s_localizableMessage = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.DoNotUseTypesFromAssemblyRuleDirectMessage), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
private static readonly LocalizableString s_localizableIndirectMessage = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.DoNotUseTypesFromAssemblyRuleIndirectMessage), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources));
private static readonly LocalizableString s_localizableDescription = new LocalizableResourceString(nameof(CodeAnalysisDiagnosticsResources.DoNotUseTypesFromAssemblyRuleDescription), CodeAnalysisDiagnosticsResources.ResourceManager, typeof(CodeAnalysisDiagnosticsResources), nameof(AnalysisContext), DiagnosticAnalyzerCorrectnessAnalyzer.RegisterCompilationStartActionName);
private const string CodeActionMetadataName = "Microsoft.CodeAnalysis.CodeActions.CodeAction";
private static readonly ImmutableArray<string> s_WorkspaceAssemblyNames = ImmutableArray.Create(
"Microsoft.CodeAnalysis.Workspaces",
"Microsoft.CodeAnalysis.CSharp.Workspaces",
"Microsoft.CodeAnalysis.VisualBasic.Workspaces");
public static readonly DiagnosticDescriptor DoNotUseTypesFromAssemblyDirectRule = new DiagnosticDescriptor(
DiagnosticIds.DoNotUseTypesFromAssemblyRuleId,
s_localizableTitle,
s_localizableMessage,
DiagnosticCategory.MicrosoftCodeAnalysisCorrectness,
DiagnosticHelpers.DefaultDiagnosticSeverity,
isEnabledByDefault: DiagnosticHelpers.EnabledByDefaultIfNotBuildingVSIX,
description: s_localizableDescription,
customTags: WellKnownDiagnosticTags.Telemetry);
public static readonly DiagnosticDescriptor DoNotUseTypesFromAssemblyIndirectRule = new DiagnosticDescriptor(
DiagnosticIds.DoNotUseTypesFromAssemblyRuleId,
s_localizableTitle,
s_localizableIndirectMessage,
DiagnosticCategory.MicrosoftCodeAnalysisCorrectness,
DiagnosticHelpers.DefaultDiagnosticSeverity,
isEnabledByDefault: DiagnosticHelpers.EnabledByDefaultIfNotBuildingVSIX,
description: s_localizableDescription,
customTags: WellKnownDiagnosticTags.Telemetry);
protected abstract bool IsNamedTypeDeclarationBlock(SyntaxNode syntax);
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(DoNotUseTypesFromAssemblyDirectRule, DoNotUseTypesFromAssemblyIndirectRule);
public override void Initialize(AnalysisContext context)
{
context.EnableConcurrentExecution();
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze);
context.RegisterCompilationStartAction(compilationStartContext =>
{
if (compilationStartContext.Compilation.GetOrCreateTypeByMetadataName(CodeActionMetadataName) == null)
{
// No reference to core Workspaces assembly.
return;
}
INamedTypeSymbol diagnosticAnalyzer = compilationStartContext.Compilation.GetOrCreateTypeByMetadataName(DiagnosticAnalyzerCorrectnessAnalyzer.DiagnosticAnalyzerTypeFullName);
if (diagnosticAnalyzer == null)
{
// Does not contain any diagnostic analyzers.
return;
}
var hasAccessToTypeFromWorkspaceAssemblies = false;
var namedTypesToAccessedTypesMap = new ConcurrentDictionary<INamedTypeSymbol, ImmutableHashSet<INamedTypeSymbol>>();
var diagnosticAnalyzerTypes = new ConcurrentBag<INamedTypeSymbol>();
compilationStartContext.RegisterSymbolAction(symbolContext =>
{
var namedType = (INamedTypeSymbol)symbolContext.Symbol;
if (namedType.DerivesFrom(diagnosticAnalyzer, baseTypesOnly: true))
{
diagnosticAnalyzerTypes.Add(namedType);
}
var usedTypes = GetUsedNamedTypes(namedType, symbolContext.Compilation, symbolContext.CancellationToken, ref hasAccessToTypeFromWorkspaceAssemblies);
var added = namedTypesToAccessedTypesMap.TryAdd(namedType, usedTypes);
Debug.Assert(added);
}, SymbolKind.NamedType);
compilationStartContext.RegisterCompilationEndAction(compilationEndContext =>
{
if (diagnosticAnalyzerTypes.IsEmpty || !hasAccessToTypeFromWorkspaceAssemblies)
{
return;
}
var typesToProcess = new Queue<INamedTypeSymbol>();
var processedTypes = new HashSet<INamedTypeSymbol>();
var violatingTypeNamesBuilder = new SortedSet<string>();
var violatingUsedTypeNamesBuilder = new SortedSet<string>();
foreach (INamedTypeSymbol declaredType in namedTypesToAccessedTypesMap.Keys)
{
if (!diagnosticAnalyzerTypes.Contains(declaredType))
{
continue;
}
typesToProcess.Clear();
processedTypes.Clear();
violatingTypeNamesBuilder.Clear();
violatingUsedTypeNamesBuilder.Clear();
typesToProcess.Enqueue(declaredType);
do
{
var typeToProcess = typesToProcess.Dequeue();
Debug.Assert(typeToProcess.ContainingAssembly.Equals(declaredType.ContainingAssembly));
Debug.Assert(namedTypesToAccessedTypesMap.ContainsKey(typeToProcess));
foreach (INamedTypeSymbol usedType in namedTypesToAccessedTypesMap[typeToProcess])
{
if (usedType.ContainingAssembly != null &&
s_WorkspaceAssemblyNames.Contains(usedType.ContainingAssembly.Name))
{
violatingTypeNamesBuilder.Add(usedType.ToDisplayString());
violatingUsedTypeNamesBuilder.Add(typeToProcess.ToDisplayString());
}
if (!processedTypes.Contains(usedType) && namedTypesToAccessedTypesMap.ContainsKey(usedType))
{
typesToProcess.Enqueue(usedType);
}
}
processedTypes.Add(typeToProcess);
} while (typesToProcess.Count != 0);
if (violatingTypeNamesBuilder.Count > 0)
{
string[] args;
DiagnosticDescriptor rule;
if (violatingUsedTypeNamesBuilder.Count == 1 && violatingUsedTypeNamesBuilder.Single() == declaredType.ToDisplayString())
{
// Change diagnostic analyzer type '{0}' to remove all direct accesses to type(s) '{1}'
rule = DoNotUseTypesFromAssemblyDirectRule;
args = new[]
{
declaredType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat),
string.Join(", ", violatingTypeNamesBuilder)
};
}
else
{
// Change diagnostic analyzer type '{0}' to remove all direct and/or indirect accesses to type(s) '{1}', which access type(s) '{2}'
rule = DoNotUseTypesFromAssemblyIndirectRule;
args = new[]
{
declaredType.ToDisplayString(SymbolDisplayFormat.MinimallyQualifiedFormat),
string.Join(", ", violatingUsedTypeNamesBuilder),
string.Join(", ", violatingTypeNamesBuilder)
};
}
Diagnostic diagnostic = declaredType.CreateDiagnostic(rule, args);
compilationEndContext.ReportDiagnostic(diagnostic);
}
}
});
});
}
private ImmutableHashSet<INamedTypeSymbol> GetUsedNamedTypes(INamedTypeSymbol namedType, Compilation compilation, CancellationToken cancellationToken, ref bool hasAccessToTypeFromWorkspaceAssemblies)
{
var builder = PooledHashSet<INamedTypeSymbol>.GetInstance();
foreach (var decl in namedType.DeclaringSyntaxReferences)
{
var syntax = decl.GetSyntax(cancellationToken);
// GetSyntax for VB returns the StatementSyntax instead of BlockSyntax node.
syntax = syntax.FirstAncestorOrSelf<SyntaxNode>(node => IsNamedTypeDeclarationBlock(node), ascendOutOfTrivia: false) ?? syntax;
var semanticModel = compilation.GetSemanticModel(syntax.SyntaxTree);
var nodesToProcess = new Queue<(SyntaxNode node, bool inExecutableCode)>();
nodesToProcess.Enqueue((node: syntax, inExecutableCode: false));
do
{
(SyntaxNode node, bool inExecutableCode) nodeToProcess = nodesToProcess.Dequeue();
var node = nodeToProcess.node;
var inExecutableCode = nodeToProcess.inExecutableCode;
if (!inExecutableCode && !ReferenceEquals(node, syntax) && IsNamedTypeDeclarationBlock(node))
{
// Skip type member declarations.
continue;
}
if (node is TTypeSyntax typeSyntax)
{
var typeInfo = semanticModel.GetTypeInfo(typeSyntax, cancellationToken);
AddUsedNamedTypeCore(typeInfo.Type, builder, ref hasAccessToTypeFromWorkspaceAssemblies);
}
if (!inExecutableCode)
{
var operationBlock = semanticModel.GetOperation(node, cancellationToken);
if (operationBlock != null)
{
// Add used types within executable code in the operation tree.
inExecutableCode = true;
foreach (var operation in operationBlock.DescendantsAndSelf())
{
AddUsedNamedTypeCore(operation.Type, builder, ref hasAccessToTypeFromWorkspaceAssemblies);
// Handle static member accesses specially as there is no operation for static type off which the member is accessed.
if (operation is IMemberReferenceOperation memberReference &&
memberReference.Member.IsStatic)
{
AddUsedNamedTypeCore(memberReference.Member.ContainingType, builder, ref hasAccessToTypeFromWorkspaceAssemblies);
}
else if (operation is IInvocationOperation invocation &&
(invocation.TargetMethod.IsStatic || invocation.TargetMethod.IsExtensionMethod))
{
AddUsedNamedTypeCore(invocation.TargetMethod.ContainingType, builder, ref hasAccessToTypeFromWorkspaceAssemblies);
}
}
}
}
foreach (var child in node.ChildNodes())
{
nodesToProcess.Enqueue((child, inExecutableCode));
}
} while (nodesToProcess.Count != 0);
}
return builder.ToImmutableAndFree();
}
private static void AddUsedNamedTypeCore(ITypeSymbol typeOpt, PooledHashSet<INamedTypeSymbol> builder, ref bool hasAccessToTypeFromWorkspaceAssemblies)
{
if (typeOpt is INamedTypeSymbol usedType &&
usedType.TypeKind != TypeKind.Error)
{
builder.Add(usedType);
if (!hasAccessToTypeFromWorkspaceAssemblies &&
usedType.ContainingAssembly != null &&
s_WorkspaceAssemblyNames.Contains(usedType.ContainingAssembly.Name))
{
hasAccessToTypeFromWorkspaceAssemblies = true;
}
if (usedType.IsGenericType)
{
foreach (var type in usedType.TypeArguments)
{
AddUsedNamedTypeCore(type, builder, ref hasAccessToTypeFromWorkspaceAssemblies);
}
}
}
}
}
}