Test - Add tests for code coverage part2 #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcheunglci
changed the title
cheenamalhotra
requested review from
JRahnama,
johnnypham,
Kaur-Parminder and
DavoudEshtehari
cheenamalhotra
approved these changes
Nov 12, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlMetaDataTest.cs
Outdated
Show resolved
Hide resolved
…Test.cs Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
|
Removed some unnecessary asserts. Everything else LGTM. |
johnnypham
approved these changes
Nov 18, 2021
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlCommandBuilderTest.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from PR #1377 , this adds code coverage to the following classes:
SqlMetaData is at 92.8% coverage, and there are certain code blocks that's not possible to add coverage, so I can see some areas where it can be cleaned up, but my focus here is for the tests. SqlDependency is at 75% coverage, and it's a bit tricky to invoke certain exceptions.