-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test - Add tests for code coverage part 1 #1377
Merged
cheenamalhotra
merged 10 commits into
dotnet:main
from
lcheunglci:Test-CodeCoverage-part1
Nov 17, 2021
Merged
Test - Add tests for code coverage part 1 #1377
cheenamalhotra
merged 10 commits into
dotnet:main
from
lcheunglci:Test-CodeCoverage-part1
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and to verify out of range for LocaleId
…rator and GetService for netfx and CreateCommandBuilder for both
cheenamalhotra
requested review from
DavoudEshtehari,
Kaur-Parminder,
JRahnama and
johnnypham
November 9, 2021 01:29
cheenamalhotra
approved these changes
Nov 12, 2021
johnnypham
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed some unnecessary asserts. Everything else LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making a giant PR with as much code coverage tests as possible, I'm going to split them up into parts and try to open one PR per week or depending on the number of tests added/modified. I added code coverage to the following classes: