Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test - Add tests for code coverage part 1 #1377

Merged
merged 10 commits into from
Nov 17, 2021

Conversation

lcheunglci
Copy link
Contributor

Instead of making a giant PR with as much code coverage tests as possible, I'm going to split them up into parts and try to open one PR per week or depending on the number of tests added/modified. I added code coverage to the following classes:

  • SqlCollation
  • SqlConnectionStringBuilder
  • SqlClientLogger
  • SqlClientFactory
  • SqlParameterCollection
  • SqlCommandSet

@cheenamalhotra cheenamalhotra added the ✔️ Tests Identifier for test related changes label Nov 9, 2021
@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v4.0 via automation Nov 9, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0 milestone Nov 9, 2021
Copy link
Contributor

@johnnypham johnnypham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed some unnecessary asserts. Everything else LGTM.

SqlClient v4.0 automation moved this from In progress to Reviewer approved Nov 17, 2021
@cheenamalhotra cheenamalhotra merged commit d1deadd into dotnet:main Nov 17, 2021
SqlClient v4.0 automation moved this from Reviewer approved to Done Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ Tests Identifier for test related changes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants