Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up manual tests into sets #1373

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Split up manual tests into sets #1373

merged 3 commits into from
Oct 27, 2021

Conversation

johnnypham
Copy link
Contributor

@johnnypham johnnypham commented Oct 25, 2021

This change adds the ability to compile a subset of the manual tests, which will add more jobs to each CI run but reduce the duration of each job. The TestSet argument can be omitted to compile all tests or can be given the following values:

-p:TestSet=1
-p:TestSet=2
-p:TestSet=3
-p:TestSet=AE

@cheenamalhotra
Copy link
Member

Could we simplify by saying -p:TestSet=1 and so on?

@johnnypham
Copy link
Contributor Author

Could we simplify by saying -p:TestSet=1 and so on?

Updated.

@cheenamalhotra cheenamalhotra added the ✔️ Tests Identifier for test related changes label Oct 26, 2021
Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update BuildGuide and we're good to merge 👍🏻

@cheenamalhotra cheenamalhotra added this to In progress in SqlClient v4.0 via automation Oct 26, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0 milestone Oct 26, 2021
@cheenamalhotra cheenamalhotra merged commit 78e8ebc into dotnet:main Oct 27, 2021
SqlClient v4.0 automation moved this from In progress to Done Oct 27, 2021
@johnnypham johnnypham deleted the testsets branch October 27, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️ Tests Identifier for test related changes
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants