Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlSpatial #1

Closed
dotMorten opened this issue May 6, 2019 · 9 comments
Closed

SqlSpatial #1

dotMorten opened this issue May 6, 2019 · 9 comments

Comments

@dotMorten
Copy link

Will this repo also include the native source for SqlSpatial, so we can cross compile it and get proper support for these types on Android/iOS/ etc?

@David-Engel
Copy link
Contributor

I assume you mean the namespaces System.Data.Spatial and System.Data.Objects.SqlClient (containing SqlSpatialFunctions).

No. Spatial is still an existing feature gap between Framework and Core and not one we've targeted as part of this project. We do realize it is still a gap that needs to be filled, though. I don't have any insight for when that might happen.

@dotMorten
Copy link
Author

I meant SqlGeometry, SqlGeography, SqlHierachy etc from the Microsoft.SqlServer.Types package

@David-Engel
Copy link
Contributor

Ah, okay. Same answer, though. We haven't brought anything spatial related into this project.

@dotMorten
Copy link
Author

😢

@divega
Copy link

divega commented May 7, 2019

@dotMorten, the SQL Server team is aware of this feature request and and we will continue discussing with them about bringing Microsoft.SqlServer.Types forward. What can help at this point is to collect concrete data on customers that are blocked from moving their applications because this feature isn't supported in .NET Core, or because it isn't available cross-platform.

Also (@David-Engel, feel free to correct me if I am wrong), I believe when using Microsoft.Data.SqlClient on .NET Framework, the functionality is enabled, just like it is in System.Data.SqlClient on .NET Framework.

@David-Engel
Copy link
Contributor

@divega I'm unfamiliar with Microsoft.SqlServer.Types but I don't see any dependencies on S.D.SqlClient, so I would assume it works the same with either one, too.

@Wraith2
Copy link
Contributor

Wraith2 commented May 7, 2019

@dotMorten a similar question came up from the EFCore repo and in order to permit users to work around this problem dotnet/corefx#36678 was added which will allow you to serialize your spatial types in code and pass them through to sql as binary representations directly. That fix should/will be included in this project.

@dotMorten
Copy link
Author

One of the big problems here is these UDT types doesn't "just work", as the assembly info doesn't match anything client side (assembly name, version and public key must match). otherwise you're left with having to pull out the SqlBinary and parse it yourself. And even after that point you still don't have the same math available to perform the same operations you can perform in SQL server side. It's a really ugly story for a type that's quite literally built into SqlServer.

@MaceWindu
Copy link

@David-Engel

I don't see any dependencies on S.D.SqlClient

but it is. Check my write-up here

cheenamalhotra added a commit that referenced this issue Oct 17, 2019
johnnypham pushed a commit that referenced this issue May 13, 2020
JRahnama added a commit that referenced this issue Feb 18, 2021
* Removing BinaryFormatter from NetFx

* review comments

* fix version typo

* remove extra line

* Reverted SqlException Test

* review comments

* Review comment

* Desrialize

* addressing review comments

* Fix exception in deserialization (#1)

* review comments

* add extra line to the end of strings designer

* end of line

Co-authored-by: jJRahnama <jrahnama@simba.com>
Co-authored-by: Karina Zhou <v-jizho2@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

5 participants