New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitLab raw URLs are broken with recent GitLab installs #670
Milestone
Comments
If the URL changed in a specific version forward we will need to do two things:
The implementation for BitBucket already does this, so we would want to use a similar approach. |
rgl
added a commit
to rgl/sourcelink
that referenced
this issue
Apr 24, 2021
In GitLab 13.5 (at least) the url changed from, e.g.: https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs To: https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs See dotnet#670
rgl
added a commit
to rgl/sourcelink
that referenced
this issue
Aug 15, 2021
In GitLab 12.0 the url changed from, e.g.: https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs To: https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs See https://gitlab.com/gitlab-org/gitlab/-/issues/28848 See dotnet#670
rgl
added a commit
to rgl/sourcelink
that referenced
this issue
Aug 15, 2021
The url changed from, e.g.: https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs To: https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs See https://gitlab.com/gitlab-org/gitlab/-/issues/28848 See dotnet#670
rgl
added a commit
to rgl/sourcelink
that referenced
this issue
Aug 15, 2021
The url changed from, e.g.: https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs To: https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs See https://gitlab.com/gitlab-org/gitlab/-/issues/28848 See dotnet#670
tmat
pushed a commit
that referenced
this issue
Aug 16, 2021
The url changed from, e.g.: https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs To: https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs See https://gitlab.com/gitlab-org/gitlab/-/issues/28848 See #670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current GitLab generates raw URLs alike:
But in GitLab 13.5 (at least; didn't test with earlier version) they are broken. GitLab now needs this:
I'm not really sure how to deal with older/newer URLs... would it be enough to submit a PR for changing the URL by changing the code at
sourcelink/src/SourceLink.GitLab/GetSourceLinkUrl.cs
Line 20 in f61f347
The text was updated successfully, but these errors were encountered: