Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source link on arm/arm64 processors #231

Closed
eerhardt opened this issue Jan 16, 2019 · 5 comments · Fixed by #288
Closed

Enable source link on arm/arm64 processors #231

eerhardt opened this issue Jan 16, 2019 · 5 comments · Fixed by #288
Labels

Comments

@eerhardt
Copy link
Member

According to https://github.com/dotnet/corefx/pull/34607/files#r248404919, source link is not supported on arm/arm64 chips.

Since the .NET Core SDK works on these processors, it would seem that enabling source link would make sense.

@bording
Copy link

bording commented Jan 16, 2019

The reason ARM isn't supported is because LibGit2Sharp is used, and that relies on native libgit2 binaries. We provide x86 and x64 for Windows, mac, and several linux distros, but I'm not even sure what would be involved in getting a native ARM binary built. It would also likely need to be distro-specific as well, since libgit2 has an OpenSSL dependency on linux.

@tmat
Copy link
Member

tmat commented Jan 16, 2019

@bording Would it make sense to reimplement the parts of LibGit2 that SourceLink uses in C#? That would solve a lot of issues, but of course it's a quite a bit of work as well.

@tmat
Copy link
Member

tmat commented Jan 16, 2019

@boarding If we decided to do this (port the code to C#), would it make sense to do so and maintain the port in LibGit2Sharp repo or rather in Source Link repo?

@bording
Copy link

bording commented Jan 16, 2019

@bording Would it make sense to reimplement the parts of LibGit2 that SourceLink uses in C#? That would solve a lot of issues, but of course it's a quite a bit of work as well.

That does seem like a rather large undertaking. You're basically talking about re-implementing some portion of https://github.com/libgit2/libgit2.

If you were to do that, it seems like a shame to keep it just to this repo, since lots of other people could potentially benefit. However, I'm not sure it would make sense for it to be in LibGit2Sharp or not.

Seems like something that would be worth discussing with the libgit2 maintainers first, though (of which I'm not. I can only claim some level of influence over LibGit2Sharp).

@tmat
Copy link
Member

tmat commented Jun 22, 2019

Fixed by #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants