Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceLink and BitBucketServer - not using correct URL #199

Closed
russellcoombes opened this issue Oct 29, 2018 · 1 comment
Closed

SourceLink and BitBucketServer - not using correct URL #199

russellcoombes opened this issue Oct 29, 2018 · 1 comment
Milestone

Comments

@russellcoombes
Copy link

russellcoombes commented Oct 29, 2018

Hi,

I have posted this inquiry here also - I am posting it here again in the hope that someone else might have some useful knowledge they could share.

I am attempting to utilise SourceLink for packages that I am hosting in the company Bitbucket server ( which is on version 4.9.1.) This version requires the SourceLink URL to be created with the suffix "?at=my_commit_number".

The libraries are targeting .net Framework 4.5.2 (we are not using dotnet core), and I have included the package microsoft.sourcelink.bitbucket.git (plus supporting packages - all version 1.0.0-beta-63401-01) in the project that I am looking to package up. The project is also using SourceLink.Create.CommandLine version 2.8.3. I have also tried using microsoft.sourcelink.bitbucket.git versions 1.0.0-beta-63127-02 with no difference in results.

I am using a cake script to call into MSBuild (version 15.7.180.61344), specifically setting the MSBuildSettings to contain the following properties:

`settings

.WithProperty("SourceLinkCreate", "true")
.WithProperty("SourceLinkServerType", "BitBucketServer")
.WithProperty("SourceLinkUrl", "ssh://git@my.company.bitbucketserver/projectname/projectname.git")`

However, no matter what I change, the package is always created with PDBs that contain a URL in the BitBucket format, not the BitBucketServer format. Additionally - I have also tried setting the SourceLinkUrl and SourceLinkServer type in the project's csproj file as well as the project's nuspec file. The result is always the same - a URL that cannot be resolved as the commit number is presented halfway through the URL and not with the suffix "?at=my_commit_number". And then obviously, the module cannot be loaded in Visual Studio.

I have read several articles, one of which has noted that the BitBucketServerUrlConverter has already been released. Can anyone confirm if there is any problem in using the SourceLinkUrl that I provide to convert to a valid BitBucketServer URL using the above converter when being set into the package?

Many thanks,
Russell

@tmat tmat added this to the future milestone Oct 8, 2019
@tmat
Copy link
Member

tmat commented Nov 4, 2019

We have made several improvements and fixes in BitBucket support. Please try the latest package (version 1.0.0-beta2-19554-01). Feel free to reopen this issue if you find any problems with the package.

See https://github.com/dotnet/sourcelink/blob/master/README.md#bitbucket for an updated doc.

@tmat tmat closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants