Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github sourcelink does not work; it generates wrong URLs? #1159

Open
sokunna opened this issue Dec 12, 2023 · 2 comments
Open

github sourcelink does not work; it generates wrong URLs? #1159

sokunna opened this issue Dec 12, 2023 · 2 comments

Comments

@sokunna
Copy link

sokunna commented Dec 12, 2023

I am using .net 8 which has SourceLink enabled by default. DebugType is set to embedded and nuget package seems to be created correctly when looking in nuget package explorer. However clicking on the source URLs takes me to a 404 not found page. When attempting to step into the source code in Visual Studio, it does not attempt to download any source code from github, but instead it's asking me to browse to the source file locally instead.
image

Modules says it's partially decomplied?
image
image

I also got the same result when using .net 6 or .net standard projects (with the instruction here https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-improve-diagnostics-debugging-with-sourcelink?view=vs-2022).

Any help is appreciated!

@tmat
Copy link
Member

tmat commented Dec 12, 2023

@clairernovotny

@stijnherreman
Copy link

Is it a private repository? Because then it's expected behaviour. The links point directly to raw.githubusercontent.com, while the 'Raw' button on GitHub points to github.com and redirects to raw.githubusercontent.com with a ?token=... query parameter added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants