Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArPow] Remove patches related to sourcelink and aspnetcore consumption #2362

Closed
MichaelSimons opened this issue Aug 6, 2021 · 1 comment
Closed

[ArPow] Remove patches related to sourcelink and aspnetcore consumption #2362

MichaelSimons opened this issue Aug 6, 2021 · 1 comment
Labels
area-patch-removal Removing patches for contributing repos from source-build
Projects
Source-Build Project
Milestone
6.0 Preview7

Comments

@MichaelSimons
Copy link
Member

As part of the PR to add offline CI, a sourcelink patch was needed as well as an aspnetcore patch which worked around the issue. The sourcelink patch should be removed once the fix is picked up be sourcebuild. The aspnetcore patch should be integrated into the aspnetcore repo and the patch should be removed from source build.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-patch-removal Removing patches for contributing repos from source-build untriaged labels Aug 6, 2021
@MichaelSimons MichaelSimons added this to On Deck (6.0-Preview7) in Source-Build Project Aug 6, 2021
@dseefeld dseefeld added this to the 6.0 Preview7 milestone Aug 12, 2021
@MichaelSimons MichaelSimons moved this from On Deck (Next Drop) to On Deck (6.0-RC1) in Source-Build Project Aug 19, 2021
@MichaelSimons MichaelSimons moved this from On Deck to 6.0 in Source-Build Project Aug 26, 2021
@MichaelSimons MichaelSimons moved this from 6.0 to Servicing Backlog in Source-Build Project Oct 27, 2021
@MichaelSimons
Copy link
Member Author

Closing in lieu of #2708.

Source-Build Project automation moved this from 6.0 Servicing Backlog to Done Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-patch-removal Removing patches for contributing repos from source-build
Projects
No open projects
Source-Build Project
Done
Milestone
6.0 Preview7
Development

No branches or pull requests
2 participants
@dseefeld @MichaelSimons