Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ArPow] Onboard test-templates to arcade-powered source-build #2041

Closed
crummel opened this issue Feb 9, 2021 · 4 comments · Fixed by #2055
Closed

[ArPow] Onboard test-templates to arcade-powered source-build #2041

crummel opened this issue Feb 9, 2021 · 4 comments · Fixed by #2055
Assignees

Comments

@crummel
Copy link
Contributor

crummel commented Feb 9, 2021

No description provided.

@omajid omajid assigned omajid and unassigned omajid Feb 9, 2021
@omajid
Copy link
Member

omajid commented Feb 10, 2021

PR: dotnet/test-templates#126

@omajid
Copy link
Member

omajid commented Feb 16, 2021

PR was merged last week.

@dagood
Copy link
Member

dagood commented Feb 16, 2021

Here's an internal/official build that ran with that change that we can run through the source-build-side stage 3: https://dev.azure.com/dnceng/internal/_build/results?buildId=995058&view=results

@dagood
Copy link
Member

dagood commented Feb 16, 2021

I took a look, and the artifacts look reasonable. The prebuilt report is pointing out that it seems to be missing <SourceBuild...> elements to grab ArPow-built arcade, ref packages, sourcelink, and xliff-tasks. Everything there except the Arcade one requires darc, to set up subscriptions, so I think it's reasonable to leave it as it is for now and burn down these prebuilts when we get to stage 4.

(In case I haven't mentioned it elsewhere before, these aren't going to necessarily end up as prebuilts in the final tarball: the inputs and flow being more strict should force source-build usage just like it does in dotnet/source-build.)

@MichaelSimons MichaelSimons added this to Stage 3 - Artifacts greenlit in Source-Build Project Feb 26, 2021
@MichaelSimons MichaelSimons moved this from Blocked to Completed in Source-Build Project May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants