New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binaries are not being removed from VMR when building from archive #4391
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
It's because the |
FWIW, when we use the tarball from a release on github, we may not have the original source (and the .gitignore files) to copy over. |
The tool definitely depends on having the .gitignores file. I get a PR out for a quick workaround ASAP. |
Further issue, some repos have been including binaries in their .gitignore files (https://github.com/dotnet/dotnet/blob/8f3d7c26c231d54ad230f427a1005278c815dde6/src/fsharp/.gitignore#L43 for example). This has resulted in those binaries going undetected. I think that the best way forward is to just hardcode common paths that we know should be ignored. |
On the Fedora side of things, I am looking at never running prep-source-build.sh (outside of a bootstrap scenario) and manually running a delete. It's looking like this: https://pagure.io/dotnet-sig/dotnet9.0/blob/main/f/dotnet9.0.spec#_427
|
When building the VMR from archive, the binaries are not removed from the VMR by the prep script. The binary tool still runs, it just isn't removing any binaries. See this run as an example (internal Microsoft link)
The text was updated successfully, but these errors were encountered: