Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up CODEOWNERS file #40739

Closed
ViktorHofer opened this issue May 7, 2024 · 3 comments · Fixed by #41216
Closed

Clean-up CODEOWNERS file #40739

ViktorHofer opened this issue May 7, 2024 · 3 comments · Fixed by #41216
Assignees
@MiYanni

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented May 7, 2024 •
edited by akoeplinger

Some groups in it aren't public or don't have write permissions in the sdk repo.

https://github.com/dotnet/sdk/blob/main/CODEOWNERS shows errors

image
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label May 7, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer
Copy link
Member Author

cc @marcpopMSFT @MiYanni

@MiYanni MiYanni added the needs team triage Requires a full team discussion label May 7, 2024
@marcpopMSFT
Copy link
Member

should probably be dotnet/dotnet-testing-admin

@marcpopMSFT marcpopMSFT removed untriaged Request triage from a team member needs team triage Requires a full team discussion labels May 7, 2024
@MiYanni MiYanni mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiYanni MiYanni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CodeOwners file MiYanni/sdk
3 participants
@ViktorHofer @marcpopMSFT @MiYanni