Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build scripts to have common code in a common script file #9179

Open
janvorli opened this issue Oct 23, 2017 · 4 comments
Open

Refactor build scripts to have common code in a common script file #9179

janvorli opened this issue Oct 23, 2017 · 4 comments
Labels
area-Infrastructure-coreclr backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Milestone

Comments

@janvorli
Copy link
Member

Currently, the build.sh, init-tools.sh, build-packages.sh and build-test.sh contains copies of the same code e.g. for host rid detection. We should move the shared code to a shared shell script file so that we have just one copy of that code.
Later on, it would be ideal to share that code even between all of our repos.

@janvorli
Copy link
Member Author

cc: @eerhardt

@4creators
Copy link
Contributor

This same is true for cmd scripts: build.cmd, build-test.cmd, run.cmd, init-tools.cmd and tests\runtest.cmd all have duplicated functionality. Perhaps it would be good to do the same for windows scripts as well.

@jkotas
Copy link
Member

jkotas commented Oct 24, 2017

FWIW, CoreRT solved this problem by having the common setup in https://github.com/dotnet/corert/blob/master/buildscripts/buildvars-setup.cmd and https://github.com/dotnet/corert/blob/master/buildscripts/buildvars-setup.sh; and calling this script as the first thing from the main script.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure-coreclr backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity
Projects
Status: No status
Development

No branches or pull requests

4 participants