Delete simple quirks left from the ASG removal
#86726
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsMixed diffs are expected.
|
SingleAccretion
force-pushed
the
Asg-Cleanup
branch
from
77a0979
to
c88604f
Compare
SingleAccretion
force-pushed
the
Asg-Cleanup
branch
from
c88604f
to
ba523d9
Compare
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
SingleAccretion
force-pushed
the
Asg-Cleanup
branch
from
ba523d9
to
6f206bc
Compare
This was referenced Oct 28, 2023
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Diff results for #86726Assembly diffsAssembly diffs for linux/arm64 ran on windows/x64Diffs are based on 2,498,677 contexts (1,011,240 MinOpts, 1,487,437 FullOpts). MISSED contexts: base: 6,580 (0.26%), diff: 6,673 (0.27%) Overall (-54,136 bytes)
MinOpts (-35,672 bytes)
FullOpts (-18,464 bytes)
Assembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,505,259 contexts (977,766 MinOpts, 1,527,493 FullOpts). MISSED contexts: base: 6,922 (0.28%), diff: 7,003 (0.28%) Overall (-62,126 bytes)
MinOpts (-52,902 bytes)
FullOpts (-9,224 bytes)
Assembly diffs for osx/arm64 ran on windows/x64Diffs are based on 2,229,855 contexts (927,360 MinOpts, 1,302,495 FullOpts). MISSED contexts: base: 6,095 (0.27%), diff: 6,161 (0.28%) Overall (-54,772 bytes)
MinOpts (-33,128 bytes)
FullOpts (-21,644 bytes)
Assembly diffs for windows/arm64 ran on windows/x64Diffs are based on 2,308,377 contexts (929,692 MinOpts, 1,378,685 FullOpts). MISSED contexts: base: 6,353 (0.27%), diff: 6,420 (0.28%) Overall (-51,852 bytes)
MinOpts (-33,784 bytes)
FullOpts (-18,068 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,480,005 contexts (976,915 MinOpts, 1,503,090 FullOpts). MISSED contexts: base: 6,816 (0.27%), diff: 6,904 (0.28%) Overall (-77,696 bytes)
MinOpts (-55,170 bytes)
FullOpts (-22,526 bytes)
Details here Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Overall (-0.09% to -0.03%)
MinOpts (-0.04% to -0.00%)
FullOpts (-0.09% to -0.04%)
Throughput diffs for linux/x64 ran on windows/x64Overall (-0.11% to -0.03%)
MinOpts (-0.03% to -0.00%)
FullOpts (-0.11% to -0.03%)
Throughput diffs for osx/arm64 ran on windows/x64Overall (-0.09% to -0.03%)
MinOpts (-0.03% to -0.00%)
FullOpts (-0.09% to -0.04%)
Throughput diffs for windows/arm64 ran on windows/x64Overall (-0.09% to -0.03%)
MinOpts (-0.04% to -0.00%)
FullOpts (-0.09% to -0.04%)
Throughput diffs for windows/x64 ran on windows/x64Overall (-0.16% to -0.03%)
MinOpts (-0.03% to -0.00%)
FullOpts (-0.16% to -0.03%)
Details here Throughput diffs for linux/arm64 ran on linux/x64Overall (+0.08% to +0.13%)
MinOpts (+0.05% to +0.15%)
FullOpts (+0.08% to +0.16%)
Throughput diffs for linux/x64 ran on linux/x64Overall (-0.03% to +0.06%)
MinOpts (+0.02% to +0.10%)
FullOpts (-0.03% to +0.06%)
Details here Throughput diffs for linux/arm ran on windows/x86Overall (-0.02% to -0.01%)
MinOpts (-0.02% to +0.02%)
FullOpts (-0.02% to -0.01%)
Throughput diffs for windows/x86 ran on windows/x86Overall (-0.02% to -0.01%)
MinOpts (-0.03% to +0.04%)
FullOpts (-0.02% to -0.01%)
Details here |
Diff results for #86726Assembly diffsAssembly diffs for linux/arm64 ran on windows/x64Diffs are based on 2,498,677 contexts (1,011,240 MinOpts, 1,487,437 FullOpts). MISSED contexts: base: 6,580 (0.26%), diff: 6,673 (0.27%) Overall (-54,136 bytes)
MinOpts (-35,672 bytes)
FullOpts (-18,464 bytes)
Assembly diffs for linux/x64 ran on windows/x64Diffs are based on 2,505,259 contexts (977,766 MinOpts, 1,527,493 FullOpts). MISSED contexts: base: 6,922 (0.28%), diff: 7,003 (0.28%) Overall (-62,126 bytes)
MinOpts (-52,902 bytes)
FullOpts (-9,224 bytes)
Assembly diffs for windows/arm64 ran on windows/x64Diffs are based on 2,308,377 contexts (929,692 MinOpts, 1,378,685 FullOpts). MISSED contexts: base: 6,353 (0.27%), diff: 6,420 (0.28%) Overall (-51,852 bytes)
MinOpts (-33,784 bytes)
FullOpts (-18,068 bytes)
Assembly diffs for windows/x64 ran on windows/x64Diffs are based on 2,480,005 contexts (976,915 MinOpts, 1,503,090 FullOpts). MISSED contexts: base: 6,816 (0.27%), diff: 6,904 (0.28%) Overall (-77,696 bytes)
MinOpts (-55,170 bytes)
FullOpts (-22,526 bytes)
Details here Assembly diffs for linux/arm ran on windows/x86Diffs are based on 2,230,528 contexts (825,130 MinOpts, 1,405,398 FullOpts). MISSED contexts: 77,529 (3.36%) Overall (-14,128 bytes)
FullOpts (-14,128 bytes)
Assembly diffs for windows/x86 ran on windows/x86Diffs are based on 2,246,531 contexts (794,865 MinOpts, 1,451,666 FullOpts). MISSED contexts: 52,597 (2.29%) Overall (-14,264 bytes)
FullOpts (-14,264 bytes)
Details here Throughput diffsThroughput diffs for linux/arm64 ran on linux/x64Overall (+0.08% to +0.13%)
MinOpts (+0.05% to +0.15%)
FullOpts (+0.08% to +0.16%)
Throughput diffs for linux/x64 ran on linux/x64Overall (-0.03% to +0.06%)
MinOpts (+0.02% to +0.10%)
FullOpts (-0.03% to +0.06%)
Details here Throughput diffs for linux/arm ran on windows/x86Overall (-0.02% to -0.01%)
MinOpts (-0.02% to +0.02%)
FullOpts (-0.02% to -0.01%)
Throughput diffs for windows/x86 ran on windows/x86Overall (-0.02% to -0.01%)
MinOpts (-0.03% to +0.04%)
FullOpts (-0.02% to -0.01%)
Details here |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
|
@SingleAccretion Given that this is still "Draft", I presume you're keeping it open just to remember to work on it? (And not because you're waiting for review) |
Yes. |
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixed diffs are expected.