Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused resources analyzer #79745

Closed
Youssef1313 opened this issue Dec 16, 2022 · 7 comments
Closed

Unused resources analyzer #79745

Youssef1313 opened this issue Dec 16, 2022 · 7 comments
Labels
area-System.Runtime code-analyzer Marks an issue that suggests a Roslyn analyzer

Comments

@Youssef1313
Copy link
Member

PR dotnet/roslyn-analyzers#6338 attempts to implement the analyzer.

dotnet/roslyn-analyzers#6338 (comment) suggests we get this to be reviewed by dotnet/runtime team.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 16, 2022
@jeffschwMSFT jeffschwMSFT added code-analyzer Marks an issue that suggests a Roslyn analyzer Team:Runtime area-System.Runtime and removed Team:Runtime labels Dec 16, 2022
@ghost
Copy link

ghost commented Dec 16, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

PR dotnet/roslyn-analyzers#6338 attempts to implement the analyzer.

dotnet/roslyn-analyzers#6338 (comment) suggests we get this to be reviewed by dotnet/runtime team.

Author: Youssef1313
Assignees: -
Labels:

area-System.Runtime, untriaged, code-analyzer

Milestone: -

@dakersnar
Copy link
Contributor

dakersnar commented Dec 16, 2022

Hi @Youssef1313, thanks for your submission. In order to simplify our own work and ease the API (and analyzer) review process, we require proposals to generally follow a given template (and provide such a template when you select "new issues": https://github.com/dotnet/runtime/issues/new/choose). Our API review process and a link to the template/good example is here: https://github.com/dotnet/runtime/blob/main/docs/project/api-review-process.md#steps. Please resubmit this issue following that template and let me know if you have any questions.

@dakersnar dakersnar closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Dec 16, 2022
@Youssef1313
Copy link
Member Author

The template is more written for "API"s rather than analyzers, but I'll fill it.

@Youssef1313
Copy link
Member Author

#79765

@dakersnar
Copy link
Contributor

dakersnar commented Dec 16, 2022

Ahh, I see what you mean, my mistake. We might want to add an analyzer-specific template/doc in the future. Thanks anyway.

@Youssef1313
Copy link
Member Author

No problem!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime code-analyzer Marks an issue that suggests a Roslyn analyzer
Projects
None yet
Development

No branches or pull requests

3 participants