Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0][PERF][MAUI] Update Maui build Mac vmimage to macos-12 #76973

Merged

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Oct 12, 2022

Backport of: #76945 and only makes changes to perf testing yml. Updates the Maui builds to use vmImage mac-12 instead of mac-11 in order to gain access to XCode 14 when building.

Customer Impact

None, this only impacts the performance infra.

Testing

Tested on the main version of the change: https://dev.azure.com/dnceng/internal/_build/results?buildId=2018712&view=results

Risk

Low
The only impact from this will be for the performance infra.

@ghost
Copy link

ghost commented Oct 12, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of: #76945 and only makes changes to perf testing yml. Updates the Maui builds to use vmImage mac-12 instead of mac-11 in order to gain access to XCode 14 when building.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

@LoopedBard3
Copy link
Member Author

@danmoseley Is there a preferred process for getting infrastructure changes like this merged into servicing branches? Thanks.

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our official and most of our other builds are on macOS-11. Not sure if you care if that might give you some difference.

@carlossanlop
Copy link
Member

carlossanlop commented Oct 13, 2022

No need for Tactics approval (tell-mode). For this coreclr infra change, I'd like to ask @hoyosjs for a sign-off.

Edit: Ah, he did it before I sent this message 😄 . Merging now.

@carlossanlop carlossanlop merged commit aacc243 into dotnet:release/7.0 Oct 13, 2022
@LoopedBard3 LoopedBard3 deleted the 7.0PerfMauiUpdateMacVMIMage branch October 13, 2022 18:05
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants