[release/6.0] Add packaging changes for System.Text.Json

[safern]

It seems like we missed packaging changes for JSON on: fd61aef

Also fixes: #61694

[ghost]

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

---

It seems like we missed packaging changes for JSON on: fd61aef

Author:	safern
Assignees:	-
Labels:	area-System.Text.Json
Milestone:	-

[safern]

@Anipik @ericstj could you please review: 28b425b

By setting these properties on packaging.targets this was happening too late, after Version.BeforeCommonTargets.targets was imported which is where the Version property is set. So if we want to use arcade version calculation we need to import using the before common targets hooks. The reason why we were seeing package versions 6.0.1 was because the PatchVersion is set to 1.

Also, instead of setting VersionPrefix I had to instead set PatchVersion to ServicingVersion because arcade relies on that and overrides the VersionPrefix when these properties are set:
https://github.com/dotnet/arcade/blob/53cc1bc2e555aa7aea95884575d22e21d63708cf/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L76

We could avoid this complexity by just setting <Version>Major.Minor.ServicingVersion</Version> and then appending the VersionSuffix if not empty, basically copying this logic: https://github.com/dotnet/arcade/blob/53cc1bc2e555aa7aea95884575d22e21d63708cf/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L165

But it felt more right to not duplicate arcade logic on our side.

For .NET 7+ we could fix the VersionSuffix calculation in arcade and make it overridable, rather than always setting it here: https://github.com/dotnet/arcade/blob/53cc1bc2e555aa7aea95884575d22e21d63708cf/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L76

[safern]

After giving it a thought, I decided to go the simple route which is setting Version on our side. The other change was too complicated for what we wanted to achieve and felt hacky.

[ericstj]

Is this all the validation we're doing @Anipik? I thought we were going to run a reverse check here:

runtime/src/libraries/shims/ApiCompat.proj

Lines 103 to 108 in c1e9122

	<Exec Command="$(_ApiCompatCommand) &quot;$(PreviousNetCoreAppRefPath.TrimEnd('\/'))&quot; @&quot;$(ApiCompatResponseFile)&quot; $(_previousNetCoreAppBaselineParam)"
	CustomErrorRegularExpression="^[a-zA-Z]+ :"
	StandardOutputImportance="Low"
	IgnoreExitCode="true">
	<Output TaskParameter="ExitCode" PropertyName="ApiCompatExitCode" />
	</Exec>

To ensure folks don't add API in servicing.

[safern]

We have an open issue, we haven't enabled it yet.

[ericstj]

Don't treat my comment as blocking. Merge when ready.

[safern]

Failure is: #50748