Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Formats.Cbor: Backport MS Docs documentation to triple slash #48985

Closed
carlossanlop opened this issue Mar 2, 2021 · 4 comments · Fixed by #49506
Closed

System.Formats.Cbor: Backport MS Docs documentation to triple slash #48985

carlossanlop opened this issue Mar 2, 2021 · 4 comments · Fixed by #49506
Labels
area-System.Formats.Cbor documentation Documentation bug or enhancement, does not impact product or test code
Milestone

Comments

@carlossanlop
Copy link
Member

We are working on a new documentation process plan, in which the main objective is to make triple slash comments the source of truth for documentation, instead of MS Docs: We want developers/maintainers to have an easier time maintaining the documentation for their APIs.

You can use the DocsPortingTool to automate the backport process: Run the tool targeting the assembly, then submit a PR with the changes.

You can find detailed instructions for the backporting process here.

Area owners are free to decide if they want to address this in 6.0 or in Future.

@carlossanlop carlossanlop added documentation Documentation bug or enhancement, does not impact product or test code area-System.Formats.Cbor labels Mar 2, 2021
@carlossanlop carlossanlop added this to To do in Documentation backport via automation Mar 2, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Tagging subscribers to this area: @eiriktsarpalis, @bartonjs
See info in area-owners.md if you want to be subscribed.

Issue Details

We are working on a new documentation process plan, in which the main objective is to make triple slash comments the source of truth for documentation, instead of MS Docs: We want developers/maintainers to have an easier time maintaining the documentation for their APIs.

You can use the DocsPortingTool to automate the backport process: Run the tool targeting the assembly, then submit a PR with the changes.

You can find detailed instructions for the backporting process here.

Area owners are free to decide if they want to address this in 6.0 or in Future.

Author: carlossanlop
Assignees: -
Labels:

area-System.Formats.Cbor, documentation

Milestone: -

@eiriktsarpalis
Copy link
Member

FWIW all CBOR documentation has been authored via triple-slash comments and automatically ported to dotnet-api-docs. We'd probably still need to backport to account for any changes that have been made on dotnet-api-docs only.

@eiriktsarpalis
Copy link
Member

I tried running the backporting tool for CBOR and got the following errors:

$ DocsPortingTool -Direction ToTripleSlash -CsProj runtime/src/libraries/System.Formats.Cbor/src/System.Formats.Cbor.csproj -Docs dotnet-api-docs/xml/ -IncludedAssemblies System.Formats.Cbor -IncludedNamespaces System.Formats.Cbor -Save true
Verifying CLI arguments...
Specified Docs xml locations:
  -  dotnet-api-docs/xml/
Included assemblies:
 - System.Formats.Cbor
Included namespaces:
 - System.Formats.Cbor
Save:
 - True
Looking for Docs xml files...
Type 'T:System.Formats.Cbor.CborConformanceMode' added with 4 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborConformanceMode.xml
Type 'T:System.Formats.Cbor.CborContentException' added with 3 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborContentException.xml
Type 'T:System.Formats.Cbor.CborReader' added with 40 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborReader.xml
Type 'T:System.Formats.Cbor.CborReaderState' added with 21 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborReaderState.xml
Type 'T:System.Formats.Cbor.CborSimpleValue' added with 4 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborSimpleValue.xml
Type 'T:System.Formats.Cbor.CborTag' added with 16 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborTag.xml
Type 'T:System.Formats.Cbor.CborWriter' added with 41 member(s) included: C:\Users\eirik\devel\dotnet\dotnet-api-docs\xml\System.Formats.Cbor\CborWriter.xml
Finished looking for Docs xml files.

Reading source code projects...
Created a workspace for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Opened the project 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Obtained the compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborConformanceMode' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborContentException' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborReader' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborReaderState' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborSimpleValue' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborTag' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Type symbol 'System.Formats.Cbor.CborWriter' not found in compilation for 'C:\Users\eirik\devel\dotnet\runtime\src\libraries\System.Formats.Cbor\src\System.Formats.Cbor.csproj'.
Porting comments from Docs to triple slash...

This is after running both Debug and Release builds in dotnet/runtime. Could you take a look?

@carlossanlop
Copy link
Member Author

Known issue: dotnet/api-docs-sync#36 and we just merged a fix: dotnet/api-docs-sync#40

Can you please update the tool to the latest bits and re-run it?

BTW, the -Save true agument is not necessary. I have updated the tutorials to remove it.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 11, 2021
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Mar 28, 2021
@eiriktsarpalis eiriktsarpalis added this to the 6.0.0 milestone Mar 28, 2021
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 11, 2021
Documentation backport automation moved this from To do to Done Apr 19, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Formats.Cbor documentation Documentation bug or enhancement, does not impact product or test code
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants