Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunContinueWithStressTestsNoState timing out in CI #2271

Closed
jkotas opened this issue Jan 28, 2020 · 14 comments · Fixed by #80981
Closed

RunContinueWithStressTestsNoState timing out in CI #2271

jkotas opened this issue Jan 28, 2020 · 14 comments · Fixed by #80981
Labels
area-System.Threading.Tasks disabled-test The test is disabled in source code against the issue needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Projects
Triage POD for Meta, Reflection, etc
Milestone
Future

Comments

@jkotas
Copy link
Member

jkotas commented Jan 28, 2020 •
edited by runfoapp bot 

C:\h\w\B76F0A24\w\A2D508E5\e>"C:\h\w\B76F0A24\p\dotnet.exe" exec --runtimeconfig System.Threading.Tasks.Tests.runtimeconfig.json --depsfile System.Threading.Tasks.Tests.deps.json xunit.console.dll System.Threading.Tasks.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing -notrait category=nonnetcoreapptests -notrait category=nonwindowstests  
  Discovering: System.Threading.Tasks.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Threading.Tasks.Tests (found 540 of 719 test cases)
  Starting:    System.Threading.Tasks.Tests (parallel test collections = on, max threads = 2)
    System.Threading.Tasks.Tests.TaskSchedulerTests.GetTaskSchedulersForDebugger_DebuggerAttached_ReturnsAllSchedulers [SKIP]
      Condition(s) not met: "DebuggerIsAttached"
    System.Threading.Tasks.Tests.TaskSchedulerTests.GetScheduledTasksForDebugger_DebuggerAttached_ReturnsTasksFromCustomSchedulers [SKIP]
      Condition(s) not met: "DebuggerIsAttached"
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:02:01
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:04:02
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:06:02
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:08:02
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:10:02
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:12:02
   System.Threading.Tasks.Tests: [Long Running Test] 'System.Threading.Tasks.Tests.TaskContinueWithTests.RunContinueWithStressTestsNoState', Elapsed: 00:14:02

I have seen this on multiple PRs.

Runfo Tracking Issue: system.threading.tasks.tests timeout

Build Definition Kind Run Name Console Core Dump Test Results Run Client
143308 runtime PR 80797 net8.0-browser-Release-wasm-Mono_Release-WasmTestOnBrowser-(Ubuntu.1804.Amd64)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-webassembly-staging console.log runclient.py
143308 runtime PR 80797 net8.0-browser-Release-wasm-Mono_Release-normal-(Ubuntu.1804.Amd64)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-webassembly-staging console.log runclient.py
142576 runtime PR 80806 net8.0-linux-Release-arm-CoreCLR_checked-(Alpine.314.Arm32.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-helix-arm32v7 console.log runclient.py
142319 runtime PR 80808 net8.0-browser-Release-wasm-Mono_Release-WasmTestOnBrowser-Ubuntu.2004.Amd64.Open console.log runclient.py
132384 runtime PR 80431 net8.0-Linux-Release-arm-CoreCLR_checked-(Alpine.314.Arm32.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-helix-arm32v7 console.log core dump runclient.py
132384 runtime PR 80431 net8.0-Linux-Release-arm64-CoreCLR_checked-(Alpine.314.Arm64.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.14-helix-arm64v8 console.log core dump runclient.py
131722 runtime PR 80421 net8.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
131722 runtime PR 80421 net8.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py
120942 runtime PR 79416 net8.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
1 3 6
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Threading untriaged New issue has not been triaged by the area owner labels Jan 28, 2020
@jkotas
Copy link
Member Author

jkotas commented Jan 28, 2020

Failed in #2237 on "Libraries Test Run checked coreclr Windows_NT x86 Release"

@jkotas
Copy link
Member Author

jkotas commented Feb 1, 2020

Failed in #30121

@am11 am11 mentioned this issue Feb 3, 2020
Merged
@AndyAyersMS AndyAyersMS mentioned this issue Feb 4, 2020
Merged
@jkotas jkotas added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Feb 4, 2020
@safern
Copy link
Member

safern commented Feb 5, 2020 •
edited

Also failing here: #5523

@jkotas would it make sense to disable this test from a Checked runtime at the moment?

@safern
Copy link
Member

safern commented Feb 5, 2020

Also failing in latest rolling build: https://helix.dot.net/api/2019-06-17/jobs/fb420b0a-1e5d-4e84-8bd4-0caed6c2076b/workitems/System.Threading.Tasks.Tests/console

@jkotas
Copy link
Member Author

jkotas commented Feb 5, 2020

Yes, it makes sense. Are you going to do it?

@safern
Copy link
Member

safern commented Feb 5, 2020

Are you going to do it?

Yep, I'll put up the PR for it.

@safern safern mentioned this issue Feb 5, 2020
Merged
@safern
Copy link
Member

safern commented Feb 5, 2020

#31789

@stephentoub stephentoub removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Feb 9, 2020
@stephentoub
Copy link
Member

This test does a lot of work (using words like "stress" and "torture" in it). Seems like simply disabling it on stress runtime runs was the right fix.

@vcsjones
Copy link
Member

@stephentoub this failed for me on #34086 in "Libraries Test Run release mono Linux arm64 Debug failed". Is that expected? Should it be disabled in other scenarios?

@stephentoub
Copy link
Member

Should it be disabled in other scenarios?

Probably. And probably outerloop. Almost anything with "stress" in its name should be relegated as such :)

@stephentoub stephentoub removed the untriaged New issue has not been triaged by the area owner label Apr 6, 2020
@bartonjs bartonjs mentioned this issue Apr 15, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
@Anipik Anipik added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Feb 18, 2021
@Anipik Anipik reopened this Feb 18, 2021
@CoffeeFlux
Copy link
Contributor

CoffeeFlux commented Apr 5, 2021 •
edited

Can we avoid reopening old issues like this, and instead just open a new one and link back to the previous issue?

It makes it very difficult for me (as someone who would like to look into the problem) to tell what's new and what's from over a year ago, and it's quite possible in this case that the cause is different. It should be a separate issue by default.

cc: @dotnet/runtime-infrastructure (or whoever maintains runfo)

@akoeplinger
Copy link
Member

akoeplinger commented Apr 26, 2021 •
edited

I can't find any recent instances of this and I agree with @CoffeeFlux that we should open a new issue rather than reviving a 1+ years old one if we see it again.

@ericstj
Copy link
Member

ericstj commented Apr 26, 2021 •
edited

If you're going to close this then you need to fix this test: 9332582#diff-3123496c18984a1a24e59feeace7f7ef7cb655b8867d6657dea18de934f50bfeR45

Or file a new issue and update the code to point to that new issue.

@jkotas jkotas reopened this Apr 26, 2021
@akoeplinger akoeplinger added the disabled-test The test is disabled in source code against the issue label Apr 27, 2021
@akoeplinger akoeplinger changed the title System.Threading.Tasks.Tests timing out in CI RunContinueWithStressTestsNoState timing out in CI Apr 27, 2021
@akoeplinger
Copy link
Member

Ah, didn't notice that since we didn't have the disabled-test label on the issue like we usually do when we disable a test in source. I also renamed the issue to make clear it's about this specific test.

@stephentoub stephentoub removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jul 12, 2021
@stephentoub stephentoub added this to the Future milestone Jul 12, 2021
@joperezr joperezr moved this from Needs triage to Future in Triage POD for Meta, Reflection, etc Nov 24, 2021
@ghost ghost moved this from Future to Needs triage in Triage POD for Meta, Reflection, etc Nov 24, 2021
@ghost ghost added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Nov 24, 2021
@buyaa-n buyaa-n removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Nov 24, 2021
@buyaa-n buyaa-n moved this from Needs triage to Future in Triage POD for Meta, Reflection, etc Nov 24, 2021
@ghost ghost moved this from Future to Needs triage in Triage POD for Meta, Reflection, etc Nov 24, 2021
@ghost ghost added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Threading.Tasks disabled-test The test is disabled in source code against the issue needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Projects
No open projects
Triage POD for Meta, Reflection, etc
Needs triage
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Change how a task stress test is disabled stephentoub/runtime
10 participants
@vcsjones @akoeplinger @stephentoub @CoffeeFlux @jkotas @ericstj @Anipik @safern @Dotnet-GitSync-Bot @buyaa-n