[release/8.0] Fix data race leading to a deadlock when opening QuicStream #102147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01250) * Fix data race leading to a deadlock. * Remove unwanted change * Code review feedback * Fix hang * Add assert * Fix potential crash * Code review feedback
|
Tagging subscribers to this area: @dotnet/ncl |
This was referenced May 13, 2024
karelz
approved these changes
May 13, 2024
|
email sent to shiproom for approval. |
CarnaViire
approved these changes
May 13, 2024
rzikm
added
Servicing-approved
|
Approved via email |
|
No CI failures. Good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #101250
Fixes #101233.
Fixes #100971.
Contributes to #101463
Customer Impact
Customers may encounter a deadlock when attempting to open an outbound QuicStream and the peer closes the connection at the same time.
Regression
No
Testing
Functional tests as part of CI.
Deadlock scenario tested locally by modifying the timing of the operations to make the deadlock more likely.
Risk
Low, issue is well understood and fix affects only code path for opening an outbound QuicStream, which is covered extensively by functional tests.