New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust repro file message for merged test #102141
Open
rzsc
wants to merge
3
commits into
dotnet:main
Choose a base branch
from
rzsc:adjust-repro-file-message-for-merged-test
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now the script ./src/tests/run.py outputs "Failed to create repro for test" for a failed merged test. But this comment 1288 if assembly_is_merged_tests_run: 1289 # REVIEW: Even if the test is a .dll file or .CMD file and is found, we don't know how to 1290 # build a repro case with it. from ./src/test/run.py script says that for a merged test a repro file should not be created at all. Changing the message "Failed to create repro for test" to "Skipping repro for merged test".
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
May 13, 2024
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
May 13, 2024
clamp03
reviewed
May 13, 2024
am11
added
area-Infrastructure-coreclr
and removed
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
May 13, 2024
Tagging subscribers to this area: @hoyosjs |
tomeksowi
approved these changes
May 13, 2024
@BruceForstall Could you review this PR? Thank you. |
bartlomiejko
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sirntar
approved these changes
May 14, 2024
Bajtazar
approved these changes
May 15, 2024
@BruceForstall @jkotas Could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Infrastructure-coreclr
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust message about repro file for a merged test
For now the script
./src/tests/run.py
outputs "Failed to create repro for test" for a failed merged test.But this comment
from
./src/test/run.py
script says that for a merged test a repro file should not be created at all.Changing the message "Failed to create repro for test" to "Skipping repro for merged test".
Part of #84834, cc @dotnet/samsung