New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean repository build results in: AsnXml regenerated files, be sure to check them in #101651
Comments
This shouldn't happen in a clean checkout, and I cannot reproduce it (and neither does CI) so it seems to be something that is specific to your local environment. Generally you should only get this message if you have modified any of the *Asn.xml files. The intention of the error is to say "You modified the XML, you better check in the C# that it generated, too"
Well, yes. They are types that are used as part of ASN.1 serialization. Presumably when you build, the |
While it is an older fresh pull from github, the HEAD is targeting a commit from today(55d2ada) and I ran
I frankly should have checked what exactly the |
Got it. Yeah our generated code is sensitive to line ending differences, and it sounds like you had git to default to I think this scenario should work though. I'll take a look at making changes to the |
Just curious, if the build generates then why don't they go to temp? Why check them in? Is it due to some circular dependency? |
The original reason was that the XML transformation task was missing in portable MSBuild so you had to do the generation with desktop MSBuild on Windows. Since the files are used on other platforms they had to be checked in. I don’t think this is a blocker anymore. |
From #45210
So changing that was not something I had considered without input from @bartonjs. Since the current stance is to check them in, the most sensible thing to do is to ignore the line endings when diffing. |
Thanks @vcsjones! It's always a bit difficult coming back to contribute whenever I find time and running into small things like this. So happy to see this resolved going forward :) |
Definitely. Papercuts like this add up. Thanks for writing an issue to get it fixed. |
Having followed the instructions here, attempting to build the runtime + libraries I ran into the following errors after running
build.cmd clr+libs -rc Release
. Upon a second attempt to compile, the build is successful. These two files evidently have some purpose as deleting them will regenerate them again. What is that purpose of these files, how am I suppose to deal with them? The error makes it sound like I am supposed to "check them in"(to git?). I presume that is not the case.My suggestion would be to:
.gitignore
for these files for them not to pollute the git context or some guidance around how one is suppose to deal with the filesWhen following the instructions
The text was updated successfully, but these errors were encountered: