Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Check inputs for QuicConnection.CloseAsync and QuicStream.Abort #101385

Closed
ManickaP opened this issue Apr 22, 2024 · 1 comment · Fixed by #102264
Closed

[QUIC] Check inputs for QuicConnection.CloseAsync and QuicStream.Abort #101385

ManickaP opened this issue Apr 22, 2024 · 1 comment · Fixed by #102264
Assignees
@ManickaP
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Milestone
9.0.0

Comments

@ManickaP
Copy link
Member

Follow up on dotnet/aspnetcore#55196

We should check the input values for error code if it's within the range. If not, DEBUG MsQuic crashes on assert, RELEASE doesn't, but ignores it, leaving the connection to idle out.

Depends on dotnet/aspnetcore#55282
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 22, 2024
@ManickaP ManickaP mentioned this issue Apr 22, 2024
Merged
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP ManickaP self-assigned this Apr 22, 2024
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Apr 22, 2024
@ManickaP ManickaP added this to the 9.0.0 milestone Apr 22, 2024
@ManickaP ManickaP added the enhancement Product code improvement that does NOT require public API changes/additions label Apr 22, 2024
@ManickaP ManickaP mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[QUIC] Validate Close/Abort errorCode parameter ManickaP/runtime
1 participant
@ManickaP