Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CompoundUseSiteInfo<TAssemblySymbol>.MergeAndClear for discarding diagnostic bag #73188

Open
jcouv opened this issue Apr 23, 2024 · 0 comments

Comments

@jcouv
Copy link
Member

jcouv commented Apr 23, 2024

If we use a discarding diagnostic bag (!AccumulatesDiagnostics), the MergeAndClear method asserts.
We should consider addressing this during MQ.

Follow-up on #72948 (comment), since we worked around with:

        internal void LookupImplicitExtensionMembersInSingleBinder(LookupResult result, TypeSymbol type,
            string name, int arity, ConsList<TypeSymbol>? basesBeingResolved, LookupOptions options,
            Binder originalBinder, ref CompoundUseSiteInfo<AssemblySymbol> useSiteInfo)
        {
...
            if (tempUseSiteInfo.AccumulatesDiagnostics)
            {
                useSiteInfo.MergeAndClear(ref tempUseSiteInfo);
            }
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 23, 2024
@jaredpar jaredpar added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 23, 2024
@jaredpar jaredpar added this to the Backlog milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants