Enable async completion #33795
Merged
Enable async completion #33795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
added
Area-Infrastructure
Integration-Test
sharwell
force-pushed
the
enable-async-completion
branch
5 times, most recently
from
5b1add8
to
e55e15c
Compare
sharwell
commented
Mar 2, 2019
src/VisualStudio/IntegrationTest/IntegrationTests/AbstractIntegrationTest.cs
Show resolved
Hide resolved
sharwell
commented
Mar 2, 2019
src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpIntelliSense.cs
Outdated
Show resolved
Hide resolved
sharwell
commented
Mar 2, 2019
src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpIntelliSense.cs
Show resolved
Hide resolved
sharwell
force-pushed
the
enable-async-completion
branch
from
e55e15c
to
e2b11da
Compare
This was referenced Mar 2, 2019
| @@ -99,7 +101,7 @@ public void CtrlAltSpace() | |||
| VisualStudio.Editor.Verify.CurrentLineText("System.Console.WriteLine();$$", assertCaretPosition: true); | |||
| VisualStudio.Editor.SendKeys(VirtualKey.Home, Shift(VirtualKey.End), VirtualKey.Delete); | |||
|
|
|||
| VisualStudio.ExecuteCommand(WellKnownCommandNames.Edit_ToggleCompletionMode); | |||
| VisualStudio.Editor.SendKeys(new KeyPress(VirtualKey.Space, ShiftState.Ctrl | ShiftState.Alt)); | |||
There was a problem hiding this comment.
Change is fine but just checking here -- did we break the command?
There was a problem hiding this comment.
No, the command works, and we use the command in other test contexts. This was supposed to be a test for Ctrl+Alt+Space though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests impacted by the following bugs are disabled until we can address them:
Fixes #33797