From 8faf89c4266ab88f0e0c34830d35c6c68b50fe7d Mon Sep 17 00:00:00 2001 From: Manish Vasani Date: Tue, 1 Oct 2019 13:05:16 -0700 Subject: [PATCH] Post release activities for 2.9.5 package release Followed the steps at https://github.com/dotnet/roslyn-analyzers/blob/master/PostReleaseActivities.md --- .github/ISSUE_TEMPLATE.md | 10 ++++----- VERSIONING.md | 1 + eng/Versions.props | 6 ++--- .../CodeFixerExtensions.cs | 3 +-- .../MetaCompilation.Analyzers.sarif | 2 +- .../UnitTests/Verifiers/DiagnosticVerifier.cs | 2 +- .../Microsoft.CodeAnalysis.Analyzers.sarif | 6 ++--- ...soft.CodeAnalysis.BannedApiAnalyzers.sarif | 6 ++--- .../Microsoft.CodeAnalysis.FxCopAnalyzers.md | 2 +- ...icrosoft.CodeAnalysis.FxCopAnalyzers.sarif | 22 +++++++++---------- ...ft.CodeAnalysis.VersionCheckAnalyzer.sarif | 2 +- .../Microsoft.CodeQuality.Analyzers.sarif | 8 +++---- .../Microsoft.NetCore.Analyzers.md | 2 +- .../Microsoft.NetCore.Analyzers.sarif | 8 +++---- .../Microsoft.NetFramework.Analyzers.sarif | 6 ++--- ...alysis.PerformanceSensitiveAnalyzers.sarif | 4 ++-- ...soft.CodeAnalysis.PublicApiAnalyzers.sarif | 4 ++-- src/ReleaseNotesUtil/FixerExtensions.cs | 3 +-- src/ReleaseNotesUtil/Program.cs | 2 +- .../Roslyn.Diagnostics.Analyzers.sarif | 14 ++++++------ .../DiagnosticAnalyzerTests.Extensions.cs | 2 +- .../IEnumerableOfIMethodSymbolExtensions.cs | 2 +- 22 files changed, 58 insertions(+), 59 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index ae31f7a019..e7dc41bdb7 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,10 +1,10 @@ #### Analyzer package -Example: [Microsoft.CodeAnalysis.FxCopAnalyzers](https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers) +[Microsoft.CodeAnalysis.FxCopAnalyzers](https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers) #### Package Version -Example: v2.9.5-beta1.final (Latest) +v2.9.5 (Latest) #### Diagnostic ID @@ -12,9 +12,9 @@ Example: [CA1716](https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1 #### Repro steps -1. One -1. Two -1. Three +1. +2. +3. #### Expected behavior diff --git a/VERSIONING.md b/VERSIONING.md index 7176253d97..5201170d5c 100644 --- a/VERSIONING.md +++ b/VERSIONING.md @@ -41,3 +41,4 @@ Sr. No. | Release Version | Commit Tag | Commit SHA 21 | 2.9.4-beta1.final (pre-release) | v2.9.4-beta1.final | [3b22a6a](https://github.com/dotnet/roslyn-analyzers/commit/3b22a6a82d450350ab0cf27504adab8d1226b2a8) | Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.FxCopAnalyzers, Microsoft.CodeAnalysis.Metrics, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.CodeQuality.Analyzers, Microsoft.NetCore.Analyzers, Microsoft.NetFramework.Analyzers, Roslyn.Diagnostics.Analyzers, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers, Microsoft.CodeAnalysis.FlowAnalysis.Utilities 22 | 2.9.4 | v2.9.4 | [a1a198d](https://github.com/dotnet/roslyn-analyzers/commit/a1a198d1c5d2359e93dd4ab4b1c4f7421512724e) | Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.FxCopAnalyzers, Microsoft.CodeAnalysis.Metrics, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.CodeQuality.Analyzers, Microsoft.NetCore.Analyzers, Microsoft.NetFramework.Analyzers, Roslyn.Diagnostics.Analyzers, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers, Microsoft.CodeAnalysis.FlowAnalysis.Utilities 23 | 2.9.5-beta1.final (pre-release) | v2.9.5-beta1.final | [494de6f](https://github.com/dotnet/roslyn-analyzers/commit/494de6f80082746e41d69355535f8dc3bfef494a) | Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.FxCopAnalyzers, Microsoft.CodeAnalysis.Metrics, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.CodeQuality.Analyzers, Microsoft.NetCore.Analyzers, Microsoft.NetFramework.Analyzers, Roslyn.Diagnostics.Analyzers, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers +24 | 2.9.5 | v2.9.5 | [6c05175](https://github.com/dotnet/roslyn-analyzers/commit/6c05175f91bf7cc463a1b71e1f6773d4afcaa7a1) | Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.FxCopAnalyzers, Microsoft.CodeAnalysis.Metrics, Microsoft.CodeAnalysis.VersionCheckAnalyzer, Microsoft.CodeQuality.Analyzers, Microsoft.NetCore.Analyzers, Microsoft.NetFramework.Analyzers, Roslyn.Diagnostics.Analyzers, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers, Microsoft.CodeAnalysis.FlowAnalysis.Utilities diff --git a/eng/Versions.props b/eng/Versions.props index d8e5a9e8bf..8b282448a2 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -2,9 +2,9 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) - 2.9.5 + 2.9.6 2.9.7 - beta2 + beta1 true @@ -21,7 +21,7 @@ 2.9.0 3.3.1-beta3-final - 2.9.5-beta1.final + 2.9.5 3.0.0-beta2.19218.3+e96bad97 3.3.0-beta2-19376-02 2.0.0-pre-20160714 diff --git a/src/GenerateAnalyzerRulesets/CodeFixerExtensions.cs b/src/GenerateAnalyzerRulesets/CodeFixerExtensions.cs index 982489164b..4163e3c9e4 100644 --- a/src/GenerateAnalyzerRulesets/CodeFixerExtensions.cs +++ b/src/GenerateAnalyzerRulesets/CodeFixerExtensions.cs @@ -1,7 +1,6 @@ using System; using System.Collections.Generic; using System.Collections.Immutable; -using System.Linq; using System.Reflection; using System.Runtime.CompilerServices; using Microsoft.CodeAnalysis.CodeFixes; @@ -73,7 +72,7 @@ private static bool HasImplementation(CodeFixProvider fixer) if (moveNextMethod != null) { MethodBody body = moveNextMethod.GetMethodBody(); - int? ilInstructionCount = body?.GetILAsByteArray()?.Count(); + int? ilInstructionCount = body?.GetILAsByteArray()?.Length; return ilInstructionCount != 177; } diff --git a/src/MetaCompilation.Analyzers/MetaCompilation.Analyzers.sarif b/src/MetaCompilation.Analyzers/MetaCompilation.Analyzers.sarif index 467704286e..26ddcabd14 100644 --- a/src/MetaCompilation.Analyzers/MetaCompilation.Analyzers.sarif +++ b/src/MetaCompilation.Analyzers/MetaCompilation.Analyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "MetaCompilation.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/MetaCompilation.Analyzers/UnitTests/Verifiers/DiagnosticVerifier.cs b/src/MetaCompilation.Analyzers/UnitTests/Verifiers/DiagnosticVerifier.cs index 0179d51bbb..00632a4ff8 100644 --- a/src/MetaCompilation.Analyzers/UnitTests/Verifiers/DiagnosticVerifier.cs +++ b/src/MetaCompilation.Analyzers/UnitTests/Verifiers/DiagnosticVerifier.cs @@ -106,7 +106,7 @@ private void VerifyDiagnostics(string[] sources, string language, DiagnosticAnal /// Diagnostic Results that should have appeared in the code private static void VerifyDiagnosticResults(IEnumerable actualResults, DiagnosticAnalyzer analyzer, params DiagnosticResult[] expectedResults) { - int expectedCount = expectedResults.Count(); + int expectedCount = expectedResults.Length; int actualCount = actualResults.Count(); if (expectedCount != actualCount) diff --git a/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif b/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif index 2ee83aa017..95b5f35c10 100644 --- a/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif +++ b/src/Microsoft.CodeAnalysis.Analyzers/Microsoft.CodeAnalysis.Analyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -299,7 +299,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -479,7 +479,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers.sarif b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers.sarif index a9a2e13b64..1b1b997c07 100644 --- a/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers.sarif +++ b/src/Microsoft.CodeAnalysis.BannedApiAnalyzers/Microsoft.CodeAnalysis.BannedApiAnalyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.BannedApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -14,7 +14,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -76,7 +76,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.md b/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.md index 3d3b57be83..a64eed7453 100644 --- a/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.md +++ b/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.md @@ -192,7 +192,7 @@ Sr. No. | Rule ID | Title | Category | Enabled | CodeFix | Description | 189 | CA5388 | Ensure Sufficient Iteration Count When Using Weak Key Derivation Function | Security | False | False | When deriving cryptographic keys from user-provided inputs such as password, use sufficient iteration count (at least 100k). | 190 | [CA5389](https://docs.microsoft.com/visualstudio/code-quality/ca5389) | Do Not Add Archive Item's Path To The Target File System Path | Security | False | False | When extracting files from an archive and using the archive item's path, check if the path is safe. Archive path can be relative and can lead to file system access outside of the expected file system target path, leading to malicious config changes and remote code execution via lay-and-wait technique. | 191 | CA5390 | Do Not Hard Code Encryption Key | Security | False | False | SymmetricAlgorithm's .Key property, or a method's rgbKey parameter, should never be a hardcoded value. | -192 | CA5391 | Use antiforgery tokens in ASP.NET Core MVC controllers | Security | True | False | Handling a POST, PUT, PATCH, or DELETE request without validating an antiforgery token may be vulnerable to cross-site request forgery attacks. A cross-site request forgery attack can send malicious requests from an authenticated user to your ASP.NET Core MVC controller. | +192 | CA5391 | Use antiforgery tokens in ASP.NET Core MVC controllers | Security | False | False | Handling a POST, PUT, PATCH, or DELETE request without validating an antiforgery token may be vulnerable to cross-site request forgery attacks. A cross-site request forgery attack can send malicious requests from an authenticated user to your ASP.NET Core MVC controller. | 193 | CA5392 | Use DefaultDllImportSearchPaths attribute for P/Invokes | Security | False | False | By default, P/Invokes using DllImportAttribute probe a number of directories, including the current working directory for the library to load. This can be a security issue for certain applications, leading to DLL hijacking. | 194 | CA5393 | Do not use unsafe DllImportSearchPath value | Security | False | False | There could be a malicious DLL in the default DLL search directories. Or, depending on where your application is run from, there could be a malicious DLL in the application's directory. Use a DllImportSearchPath value that specifies an explicit search path instead. The DllImportSearchPath flags that this rule looks for can be configured in .editorconfig. | 195 | CA5394 | Do not use insecure randomness | Security | False | False | {0} is an insecure random number generator. Use cryptographically secure random number generators when randomness is required for security | diff --git a/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.sarif b/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.sarif index 4180e959c5..e853f0419b 100644 --- a/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.sarif +++ b/src/Microsoft.CodeAnalysis.FxCopAnalyzers/Microsoft.CodeAnalysis.FxCopAnalyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.VersionCheckAnalyzer", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -29,7 +29,7 @@ { "tool": { "name": "Microsoft.CodeQuality.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -1509,7 +1509,7 @@ { "tool": { "name": "Microsoft.CodeQuality.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -1705,7 +1705,7 @@ { "tool": { "name": "Microsoft.CodeQuality.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -1939,7 +1939,7 @@ { "tool": { "name": "Microsoft.NetCore.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -3627,7 +3627,7 @@ "defaultLevel": "warning", "properties": { "category": "Security", - "isEnabledByDefault": true, + "isEnabledByDefault": false, "typeName": "UseAutoValidateAntiforgeryToken", "languages": [ "C#", @@ -3810,7 +3810,7 @@ { "tool": { "name": "Microsoft.NetCore.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -3960,7 +3960,7 @@ { "tool": { "name": "Microsoft.NetCore.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -4110,7 +4110,7 @@ { "tool": { "name": "Microsoft.NetFramework.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -4193,7 +4193,7 @@ { "tool": { "name": "Microsoft.NetFramework.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -4238,7 +4238,7 @@ { "tool": { "name": "Microsoft.NetFramework.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Microsoft.CodeAnalysis.VersionCheckAnalyzer/Microsoft.CodeAnalysis.VersionCheckAnalyzer.sarif b/src/Microsoft.CodeAnalysis.VersionCheckAnalyzer/Microsoft.CodeAnalysis.VersionCheckAnalyzer.sarif index c92a0e48f2..af30e9c314 100644 --- a/src/Microsoft.CodeAnalysis.VersionCheckAnalyzer/Microsoft.CodeAnalysis.VersionCheckAnalyzer.sarif +++ b/src/Microsoft.CodeAnalysis.VersionCheckAnalyzer/Microsoft.CodeAnalysis.VersionCheckAnalyzer.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.VersionCheckAnalyzer", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Microsoft.CodeQuality.Analyzers/Microsoft.CodeQuality.Analyzers.sarif b/src/Microsoft.CodeQuality.Analyzers/Microsoft.CodeQuality.Analyzers.sarif index a8ceb04c8e..a120e93485 100644 --- a/src/Microsoft.CodeQuality.Analyzers/Microsoft.CodeQuality.Analyzers.sarif +++ b/src/Microsoft.CodeQuality.Analyzers/Microsoft.CodeQuality.Analyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Humanizer", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -14,7 +14,7 @@ { "tool": { "name": "Microsoft.CodeQuality.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -1494,7 +1494,7 @@ { "tool": { "name": "Microsoft.CodeQuality.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -1690,7 +1690,7 @@ { "tool": { "name": "Microsoft.CodeQuality.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.md b/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.md index 06eb4f21db..449a2fc6f9 100644 --- a/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.md +++ b/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.md @@ -99,7 +99,7 @@ Sr. No. | Rule ID | Title | Category | Enabled | CodeFix | Description | 96 | CA5388 | Ensure Sufficient Iteration Count When Using Weak Key Derivation Function | Security | False | False | When deriving cryptographic keys from user-provided inputs such as password, use sufficient iteration count (at least 100k). | 97 | [CA5389](https://docs.microsoft.com/visualstudio/code-quality/ca5389) | Do Not Add Archive Item's Path To The Target File System Path | Security | False | False | When extracting files from an archive and using the archive item's path, check if the path is safe. Archive path can be relative and can lead to file system access outside of the expected file system target path, leading to malicious config changes and remote code execution via lay-and-wait technique. | 98 | CA5390 | Do Not Hard Code Encryption Key | Security | False | False | SymmetricAlgorithm's .Key property, or a method's rgbKey parameter, should never be a hardcoded value. | -99 | CA5391 | Use antiforgery tokens in ASP.NET Core MVC controllers | Security | True | False | Handling a POST, PUT, PATCH, or DELETE request without validating an antiforgery token may be vulnerable to cross-site request forgery attacks. A cross-site request forgery attack can send malicious requests from an authenticated user to your ASP.NET Core MVC controller. | +99 | CA5391 | Use antiforgery tokens in ASP.NET Core MVC controllers | Security | False | False | Handling a POST, PUT, PATCH, or DELETE request without validating an antiforgery token may be vulnerable to cross-site request forgery attacks. A cross-site request forgery attack can send malicious requests from an authenticated user to your ASP.NET Core MVC controller. | 100 | CA5392 | Use DefaultDllImportSearchPaths attribute for P/Invokes | Security | False | False | By default, P/Invokes using DllImportAttribute probe a number of directories, including the current working directory for the library to load. This can be a security issue for certain applications, leading to DLL hijacking. | 101 | CA5393 | Do not use unsafe DllImportSearchPath value | Security | False | False | There could be a malicious DLL in the default DLL search directories. Or, depending on where your application is run from, there could be a malicious DLL in the application's directory. Use a DllImportSearchPath value that specifies an explicit search path instead. The DllImportSearchPath flags that this rule looks for can be configured in .editorconfig. | 102 | CA5394 | Do not use insecure randomness | Security | False | False | {0} is an insecure random number generator. Use cryptographically secure random number generators when randomness is required for security | diff --git a/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.sarif b/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.sarif index 45a9d3b796..311c52d261 100644 --- a/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.sarif +++ b/src/Microsoft.NetCore.Analyzers/Microsoft.NetCore.Analyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.NetCore.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -1693,7 +1693,7 @@ "defaultLevel": "warning", "properties": { "category": "Security", - "isEnabledByDefault": true, + "isEnabledByDefault": false, "typeName": "UseAutoValidateAntiforgeryToken", "languages": [ "C#", @@ -1876,7 +1876,7 @@ { "tool": { "name": "Microsoft.NetCore.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -2026,7 +2026,7 @@ { "tool": { "name": "Microsoft.NetCore.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Microsoft.NetFramework.Analyzers/Microsoft.NetFramework.Analyzers.sarif b/src/Microsoft.NetFramework.Analyzers/Microsoft.NetFramework.Analyzers.sarif index f4b4bcebab..84ed822ea5 100644 --- a/src/Microsoft.NetFramework.Analyzers/Microsoft.NetFramework.Analyzers.sarif +++ b/src/Microsoft.NetFramework.Analyzers/Microsoft.NetFramework.Analyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.NetFramework.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -88,7 +88,7 @@ { "tool": { "name": "Microsoft.NetFramework.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -133,7 +133,7 @@ { "tool": { "name": "Microsoft.NetFramework.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/PerformanceSensitiveAnalyzers/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.sarif b/src/PerformanceSensitiveAnalyzers/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.sarif index 62cf8f61fd..dd5864ab29 100644 --- a/src/PerformanceSensitiveAnalyzers/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.sarif +++ b/src/PerformanceSensitiveAnalyzers/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -184,7 +184,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.sarif b/src/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.sarif index 523eafa901..09d29381ef 100644 --- a/src/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.sarif +++ b/src/PublicApiAnalyzers/Microsoft.CodeAnalysis.PublicApiAnalyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.PublicApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -147,7 +147,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.PublicApiAnalyzers.CodeFixes", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/ReleaseNotesUtil/FixerExtensions.cs b/src/ReleaseNotesUtil/FixerExtensions.cs index f259708a23..e8809610d1 100644 --- a/src/ReleaseNotesUtil/FixerExtensions.cs +++ b/src/ReleaseNotesUtil/FixerExtensions.cs @@ -1,7 +1,6 @@ using System; using System.Collections.Generic; using System.Collections.Immutable; -using System.Linq; using System.Reflection; using System.Runtime.CompilerServices; using Microsoft.CodeAnalysis.CodeFixes; @@ -73,7 +72,7 @@ private static bool HasImplementation(CodeFixProvider fixer) if (moveNextMethod != null) { MethodBody body = moveNextMethod.GetMethodBody(); - int? ilInstructionCount = body?.GetILAsByteArray()?.Count(); + int? ilInstructionCount = body?.GetILAsByteArray()?.Length; return ilInstructionCount != 177; } diff --git a/src/ReleaseNotesUtil/Program.cs b/src/ReleaseNotesUtil/Program.cs index 63b96d61ab..0df05d5110 100644 --- a/src/ReleaseNotesUtil/Program.cs +++ b/src/ReleaseNotesUtil/Program.cs @@ -235,7 +235,7 @@ private static List GetRules(IEnumerable dllPaths) analyzerFileReference .GetFixers() .SelectMany(fixer => fixer.FixableDiagnosticIds).ToHashSet(); - Console.WriteLine($"{dllPath} has {analyzers.Count()} analyzers, {descriptors.Count()} diagnostics, and {fixableDiagnosticIds.Count} fixers"); + Console.WriteLine($"{dllPath} has {analyzers.Length} analyzers, {descriptors.Count()} diagnostics, and {fixableDiagnosticIds.Count} fixers"); foreach (DiagnosticDescriptor descriptor in descriptors) { if (ruleInfos.Any(r => r.Id == descriptor.Id)) diff --git a/src/Roslyn.Diagnostics.Analyzers/Roslyn.Diagnostics.Analyzers.sarif b/src/Roslyn.Diagnostics.Analyzers/Roslyn.Diagnostics.Analyzers.sarif index dcd359ab5d..1ff8221976 100644 --- a/src/Roslyn.Diagnostics.Analyzers/Roslyn.Diagnostics.Analyzers.sarif +++ b/src/Roslyn.Diagnostics.Analyzers/Roslyn.Diagnostics.Analyzers.sarif @@ -5,7 +5,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.BannedApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -14,7 +14,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.CSharp.BannedApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -76,7 +76,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.PublicApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -218,7 +218,7 @@ { "tool": { "name": "Microsoft.CodeAnalysis.VisualBasic.BannedApiAnalyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -280,7 +280,7 @@ { "tool": { "name": "Roslyn.Diagnostics.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -379,7 +379,7 @@ { "tool": { "name": "Roslyn.Diagnostics.CSharp.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { @@ -473,7 +473,7 @@ { "tool": { "name": "Roslyn.Diagnostics.VisualBasic.Analyzers", - "version": "2.9.5", + "version": "2.9.6", "language": "en-US" }, "rules": { diff --git a/src/Test.Utilities/DiagnosticAnalyzerTests.Extensions.cs b/src/Test.Utilities/DiagnosticAnalyzerTests.Extensions.cs index 791dc7045e..5fc28dfea6 100644 --- a/src/Test.Utilities/DiagnosticAnalyzerTests.Extensions.cs +++ b/src/Test.Utilities/DiagnosticAnalyzerTests.Extensions.cs @@ -30,7 +30,7 @@ public static class DiagnosticAnalyzerTestsExtensions return; } - int expectedCount = expectedResults.Count(); + int expectedCount = expectedResults.Length; int actualCount = actualResults.Count(); if (expectedCount != actualCount) diff --git a/src/Utilities/Compiler/Extensions/IEnumerableOfIMethodSymbolExtensions.cs b/src/Utilities/Compiler/Extensions/IEnumerableOfIMethodSymbolExtensions.cs index 74329cf379..7f3ef30bb5 100644 --- a/src/Utilities/Compiler/Extensions/IEnumerableOfIMethodSymbolExtensions.cs +++ b/src/Utilities/Compiler/Extensions/IEnumerableOfIMethodSymbolExtensions.cs @@ -102,7 +102,7 @@ internal static class IEnumerableOfIMethodSymbolExtensions /// public static IMethodSymbol GetFirstOrDefaultMemberWithParameterInfos(this IEnumerable members, params ParameterInfo[] expectedParameterTypesInOrder) { - var expectedParameterCount = expectedParameterTypesInOrder.Count(); + var expectedParameterCount = expectedParameterTypesInOrder.Length; return members?.FirstOrDefault(member => { if (member.Parameters.Count() != expectedParameterCount)