New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AnalyzerReleases shipped file for 7.0 release #6246
Conversation
@Evangelink @jmarolf for review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6246 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 1360 1360
Lines 312054 312054
Branches 10047 10047
=======================================
+ Hits 299720 299724 +4
+ Misses 9925 9924 -1
+ Partials 2409 2406 -3 |
@jmarolf can we do an insertion of the latest NetAnalyzers package into dotnet/sdk after this change? |
let me verify that is happening |
Just installed |
@znakeeye The fix still needs to flow from this repo to dotnet/sdk repo and make it into the next .NET 7 servicing release. Additionally, VS also needs to move to the newer .NET 7 release with the fix for it to automatically light up. This whole code flow and release process can take some time, so meanwhile I would suggest you to directly install the latest prerelease NuGet package from this feed instead: https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet7/NuGet/Microsoft.CodeAnalysis.NetAnalyzers Note that you should avoid setting |
Ok, so in order to get it to work with
Correct? Or do we need 17.5p1? (I saw it was referenced here, somewhere...) |
@mavasani I can confirm this made it into the .NET SDK here: dotnet/sdk#28864. It should be part of the first servicing release. |
Thank you @jmarolf |
I suppose this was fixed in |
Yes, correct. |
Fixes #6245
I verified that locally built NuGet package with this fix resolves this issue. The NuGet package contains
analysislevel_7_XXX.editorconfig
set of editorconfig files, and settingAnalysisLevel
tolatest-XXX
orlatest
or7.0
passes in the appropriate editorconfig file to compiler command lineFiled #6247 to enhance the tooling to avoid regressions such as #6245 in future.