Update all resources in RoslynDiagnosticAnalyzerResources #3543
+1,107
−1,107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3543 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 1053 1053
Lines 237724 237724
Branches 15449 15449
=======================================
+ Hits 226065 226069 +4
+ Misses 9943 9939 -4
Partials 1716 1716 |
mavasani
reviewed
Apr 25, 2020
| </data> | ||
| <data name="DoNotInvokeDiagnosticDescriptorDescription" xml:space="preserve"> | ||
| <value>Accessing the Descriptor property of Diagnostic in compiler layer leads to unnecessary string allocations for fields of the descriptor that are not utilized in command line compilation. Hence, you should avoid accessing the Descriptor of the compiler diagnostics here. Instead you should directly access these properties off the Diagnostic type.</value> | ||
| <value>Accessing the 'Descriptor' property of 'Diagnostic' in compiler layer leads to unnecessary string allocations for fields of the descriptor that are not utilized in command line compilation. Hence, you should avoid accessing the 'Descriptor' of the compiler diagnostics here. Instead you should directly access these properties off the 'Diagnostic' type.</value> | ||
| </data> | ||
| <data name="DoNotInvokeDiagnosticDescriptorMessage" xml:space="preserve"> | ||
| <value>Do not invoke property '{0}' on type '{1}', instead directly access the required member{2} on '{1}'</value> |
There was a problem hiding this comment.
Suggested change
| <value>Do not invoke property '{0}' on type '{1}', instead directly access the required member{2} on '{1}'</value> | |
| <value>Do not invoke property '{0}' on type '{1}', instead directly access the required member '{2}' on '{1}'</value> |
There was a problem hiding this comment.
We shouldn't change this (or at least not in this PR), the code is taking care of adding the space + wrapping in single quotes when needed: https://github.com/dotnet/roslyn-analyzers/blob/master/src/Roslyn.Diagnostics.Analyzers/Core/DoNotInvokeDiagnosticDescriptor.cs#L64
There was a problem hiding this comment.
Ah got you. Can you file a separate issue for fixing this up in a separate PR?
mavasani
approved these changes
Apr 25, 2020
|
@mavasani I have replied to your comment, the resource is expected to be as it is currently. I can either keep it as-is, fix it and fix code here or create a ticket and do a separate PR to fix this. |
mavasani
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.