Performance fix for AnalysisEntityMapAbstractDomain.Merge algorithm #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now ensure that we only create new entries in the result map if the entity key is a valid tracked entity
dotpaul
reviewed
Nov 21, 2019
src/Utilities/FlowAnalysis/FlowAnalysis/Analysis/PointsToAnalysis/TrackedEntitiesBuilder.cs
Show resolved
Hide resolved
… with this fix. Working on addressing these failures in a follow-up commit.
… that new reachable entities from Merge algorithm are not skipped. This commit fixes the analysis for tests added in previous commit.
|
@dotpaul I was able to validate no performance regression in building Roslyn after this fix, let me know once your validations are done. Thanks! |
|
Other than the one case @LLLXXXCCC emailed about, the previous repros looks good to me! I'm trying a pass on a larger code base; will approve after that finishes. |
dotpaul
approved these changes
Nov 22, 2019
|
Thank you @dotpaul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now ensure that we only create new entries in the result map if the entity key is a valid tracked entity