Fix NRE in recently added AssigningSymbolAndItsMemberInSameStatement … #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analyzer Handle null operation type, which is possible for OperationKind.None Found while dogfooding the latest package
mavasani
commented
Oct 1, 2019
| @@ -50,29 +50,21 @@ private void AnalyzeAssignment(OperationAnalysisContext context) | |||
| } | |||
|
|
|||
| // This analyzer makes sense only for reference type objects | |||
| if (operationTarget.Instance?.Type.IsValueType == true) | |||
| if (operationTarget.Instance?.Type?.IsReferenceType != true) | |||
There was a problem hiding this comment.
This is the core fix for the NRE. Other change below is just applying an IDE suggestion to use switch expression.
|
Thanks @dotpaul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…analyzer
Handle null operation type, which is possible for OperationKind.None
Found while dogfooding the latest package