Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified BaseBlocking, FirstBlocking, and LastBlocking #891

Merged
merged 4 commits into from Nov 19, 2019
Merged

Simplified BaseBlocking, FirstBlocking, and LastBlocking #891

merged 4 commits into from Nov 19, 2019

Conversation

ts2do
Copy link
Contributor

@ts2do ts2do commented Apr 27, 2019

The code was needlessly bloated and over-engineered for its usage.

Switched BaseBlocking<T> to derive from ManualResetEventSlim, which is sufficient for the task at hand
@dnfclas
Copy link

dnfclas commented Apr 27, 2019

CLA assistant check
All CLA requirements met.

@dnfclas
Copy link

dnfclas commented Apr 27, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ ts2do sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@danielcweber
Copy link
Collaborator

Could you please provide some more rationale for your work? Just calling something "needlessly bloated and over-engineered" is a bold claim (I'm not suggesting it's wrong, though).

@akarnokd
Copy link
Collaborator

akarnokd commented May 9, 2019

The current structure was a port from Java and thus based on "Java feature X equivalent in C#". If there is a more lenient and C# way of accomplishing the job, improvements are always welcome.

@ts2do
Copy link
Contributor Author

ts2do commented May 10, 2019

My apologies. I agree that my original explanation was unproductive and not specific. I just wanted to make those classes a bit cleaner by making it a lighter wrapper for the event, ManualResetEventSlim being the most basic event for the job. Since the code using FirstBlocking<> and LastBlocking<> already had the subscription in a using block, a lot of the code wasn't accomplishing anything.

@danielcweber danielcweber merged commit fc17494 into dotnet:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants