Fix Generate (timed) crash upon disposing a long sequence #1067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how recursive scheduling has to link up
IDisposable
s in theUserWorkItem
class, a long running timedGenerate
would produce a long chain ofUserWorkItem
s and crash with stack overflow if the whole sequence itself is disposed.The fix is to have the recursive scheduling in
Generate
not return the next step'sIDisposable
from the function but keep replacing a main reference with the newer and newerIDisposable
s, and thus no link chain is formed.The use of the SAD indirection is necessary because when the
Schedule
returns with theIDisposable
, the payload may have already run and we would overwrite a newer step'sIDisposable
.