New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a number of nullable warnings. #1035

Merged

bartdesmet merged 2 commits into master from dev/bartde/fix_nullable_warnings

Sep 23, 2019

Collaborator

bartdesmet commented Sep 23, 2019 •

edited

Fix various C# 8.0 warnings, most notably due to:

Generated code using MethodInfo fields rather than MethodInfo?.
Test code checking for ArgumentNullException by having to pass in null.
Redundant Debug.Assert(x != null) asserts influencing nullability analysis for x.
Misc. smaller cases.


          Fix a number of nullable warnings.

0311af1

Member

clairernovotny commented Sep 23, 2019

Don't worry about the failing RxNET builds - known issue that's being dealt with separately.


          Fix a few more cases.

ec03272

bartdesmet merged commit 66266fa into master

delete-merged-branch bot deleted the dev/bartde/fix_nullable_warnings branch

September 23, 2019 20:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment