Log output is invalid for regular builds

[bording]

As originally reported in KirillOsenkov/MSBuildStructuredLog#136, it appears that the log levels are not being set correctly for regular builds. When I view a design-time log, everything is fine, but regular logs seem to be missing data. This was causing the log viewer to throw exceptions.

As mentioned in KirillOsenkov/MSBuildStructuredLog#136 (comment), manually increasing the log level of either UI option in VS appears to fix the issue.

Should this be something the extension is handling automatically? Which of the UI options should influence the log output?

[bording]

Investigating a bit more, it seems to only occur for builds from SDK-style projects. Logs from legacy projects don't cause a problem for version 1.1.168 of the log viewer (the version before the workaround @KirillOsenkov added).

FYI I'm testing this with VS 2017 15.4.5 and the 2.0.3 SDK. I also have the latest 1.0.0.6230301 version of the extension.

[KirillOsenkov]

Note that I've also seen wrong logs, I don't remember which project that was. But yes, this is definitely an issue.

[bording]

FYI, just tried this with VS 2017 15.5.0, 2.1.2 SDK, and extension 1.0.0.6232701, and no change in behavior from any of the updates.

[KirillOsenkov]

Yup, I'm still seeing it too.

[clairernovotny]

Is there a workaround, does this work from the command line instead? (for regular builds)?

[Pilchie]

it seems to only occur for builds from SDK-style projects.

I'm pretty sure I got an internal example where this wasn't the case today.

[panopticoncentral]

I'm closing this issue here because this isn't an issue with the project tools themselves. The problem is that CPS doesn't register loggers in the correct way in VS for regular builds because there's a missing API that lets them do that. I'm moving this to a VS issue and will work on resolving it there.

[bording]

@panopticoncentral Glad to hear the problem has been identified and will be fixed, but will it be possible for you to report back here when the issue is resolved? I have no visibility into your internal issue trackers.