Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set MetricsSupport=false for blazor minapp #3367

Closed
wants to merge 1 commit into from
Closed

Set MetricsSupport=false for blazor minapp #3367

wants to merge 1 commit into from

Conversation

radical
Copy link
Member

@radical radical commented Sep 27, 2023

Fixes #3341 .

@radical
Copy link
Member Author

radical commented Sep 27, 2023

@lewing is this property correct? The docs in runtime mention this as the property name, but I'm not sure what it is affecting.

LoopedBard3
LoopedBard3 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM presuming this property does what is expected.

@radical radical mentioned this pull request Sep 27, 2023
Merged
@radical
Copy link
Member Author

radical commented Sep 27, 2023

Don't merge yet. @radekdoulik opened dotnet/runtime#92696 which would supersede this one.

@radical
Copy link
Member Author

radical commented Oct 2, 2023

Closing this as the the property is set to false by default now - dotnet/runtime#92696 .

@radical radical closed this Oct 2, 2023
@radical radical deleted the blazor-min-app branch October 2, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cincuranet cincuranet cincuranet approved these changes

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@lewing lewing Awaiting requested review from lewing

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
arch-wasm *NO MERGE*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] set MetricsSupport to false for BlazorMinimumSize blazor_scenarios build
3 participants
@radical @cincuranet @LoopedBard3