From e004e4256605e7f6c7b5e0952cbf9855980595e7 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Fri, 3 Apr 2020 18:46:30 +0530 Subject: [PATCH 1/2] Remove all trailing spaces only in MSBuild Common props, targets and tasks files Conforming to the repository's EditorConfig file --- .../Microsoft.CSharp.CurrentVersion.targets | 40 ++++----- src/Tasks/Microsoft.CSharp.targets | 82 +++++++++---------- .../Microsoft.Common.CrossTargeting.targets | 12 +-- .../Microsoft.Common.CurrentVersion.targets | 10 +-- src/Tasks/Microsoft.Common.overridetasks | 4 +- src/Tasks/Microsoft.Common.props | 70 ++++++++-------- src/Tasks/Microsoft.Common.targets | 64 +++++++-------- src/Tasks/Microsoft.Common.tasks | 5 +- src/Tasks/Microsoft.Data.Entity.targets | 12 +-- src/Tasks/Microsoft.NET.props | 2 +- ...rosoft.NETFramework.CurrentVersion.targets | 8 +- src/Tasks/Microsoft.NETFramework.props | 22 ++--- src/Tasks/Microsoft.NETFramework.targets | 28 +++---- src/Tasks/Microsoft.ServiceModel.targets | 12 +-- ...crosoft.VisualBasic.CurrentVersion.targets | 38 ++++----- src/Tasks/Microsoft.VisualBasic.targets | 82 +++++++++---------- src/Tasks/Microsoft.WinFx.targets | 12 +-- .../Microsoft.WorkflowBuildExtensions.targets | 12 +-- src/Tasks/Microsoft.Xaml.targets | 16 ++-- src/Tasks/Workflow.VisualBasic.targets | 14 ++-- src/Tasks/Workflow.targets | 14 ++-- 21 files changed, 279 insertions(+), 280 deletions(-) diff --git a/src/Tasks/Microsoft.CSharp.CurrentVersion.targets b/src/Tasks/Microsoft.CSharp.CurrentVersion.targets index a14d5b42df4..6b433c425c9 100644 --- a/src/Tasks/Microsoft.CSharp.CurrentVersion.targets +++ b/src/Tasks/Microsoft.CSharp.CurrentVersion.targets @@ -8,7 +8,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and This file defines the steps in the standard build process specific for C# .NET projects. For example, it contains the step that actually calls the C# compiler. The remainder -of the build process is defined in Microsoft.Common.targets, which is imported by +of the build process is defined in Microsoft.Common.targets, which is imported by this file. Copyright (C) Microsoft Corporation. All rights reserved. @@ -66,14 +66,14 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + <_Temporary Remove="@(_Temporary)" /> - + $(CoreCompileDependsOn);_ComputeNonExistentFileProperty;ResolveCodeAnalysisRuleSet true - + $(AppConfig) - - + + $(IntermediateOutputPath)$(TargetName).compile.pdb @@ -231,12 +231,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. false - + - + true @@ -259,7 +259,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. DisabledWarnings="$(NoWarn)" DocumentationFile="@(DocFileItem)" EmitDebugInformation="$(DebugSymbols)" - EnvironmentVariables="$(CscEnvironment)" + EnvironmentVariables="$(CscEnvironment)" ErrorEndLocation="$(ErrorEndLocation)" ErrorLog="$(ErrorLog)" ErrorReport="$(ErrorReport)" @@ -279,7 +279,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. Nullable="$(Nullable)" Optimize="$(Optimize)" OutputAssembly="@(XamlIntermediateAssembly)" - PdbFile="$(PdbFile)" + PdbFile="$(PdbFile)" Platform="$(PlatformTarget)" Prefer32Bit="$(Prefer32Bit)" PreferredUILang="$(PreferredUILang)" @@ -322,7 +322,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + @@ -360,12 +360,12 @@ using System.Reflection%3b $([System.Globalization.CultureInfo]::CurrentUICulture.Name) - + diff --git a/src/Tasks/Microsoft.CSharp.targets b/src/Tasks/Microsoft.CSharp.targets index beda9624db2..73cfe2c94b5 100644 --- a/src/Tasks/Microsoft.CSharp.targets +++ b/src/Tasks/Microsoft.CSharp.targets @@ -8,7 +8,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and This file defines the steps in the standard build process specific for C# .NET projects. For example, it contains the step that actually calls the C# compiler. The remainder -of the build process is defined in Microsoft.Common.targets, which is imported by +of the build process is defined in Microsoft.Common.targets, which is imported by this file. Copyright (C) Microsoft Corporation. All rights reserved. @@ -17,17 +17,17 @@ Copyright (C) Microsoft Corporation. All rights reserved. @@ -35,7 +35,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildFrameworkToolsPath)\Microsoft.CSharp.targets - $(MsBuildFrameworkToolsPath) @@ -54,14 +54,14 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(ImportByWildcardBeforeMicrosoftCommonTargets) true @@ -106,15 +106,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(ImportByWildcardBeforeMicrosoftNetFrameworkProps) true @@ -137,24 +137,24 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + - + targets), we're stuck doing it this way instead. --> - + - + targets), and Microsoft.Common.targets does likewise with Microsoft.NETFramework.props, we're stuck doing it this + way instead. --> - + @@ -164,29 +164,29 @@ Copyright (C) Microsoft Corporation. All rights reserved. + targets), and Microsoft.Common.targets does likewise with Microsoft.NETFramework.props, we're stuck doing it this + way instead. --> - + - + targets), we're stuck doing it this way instead. --> - + - + - $(MSBuildFrameworkToolsPath) diff --git a/src/Tasks/Microsoft.Common.CrossTargeting.targets b/src/Tasks/Microsoft.Common.CrossTargeting.targets index c5ce7a2d79e..3b3e8a1d191 100644 --- a/src/Tasks/Microsoft.Common.CrossTargeting.targets +++ b/src/Tasks/Microsoft.Common.CrossTargeting.targets @@ -33,7 +33,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + <_ThisProjectBuildMetadata Include="$(MSBuildProjectFullPath)"> @(_TargetFrameworkInfo) @@ -178,7 +178,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true - @@ -202,7 +202,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true - @@ -215,6 +215,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. - diff --git a/src/Tasks/Microsoft.Common.CurrentVersion.targets b/src/Tasks/Microsoft.Common.CurrentVersion.targets index 18d7712ad5c..16ef51e2538 100644 --- a/src/Tasks/Microsoft.Common.CurrentVersion.targets +++ b/src/Tasks/Microsoft.Common.CurrentVersion.targets @@ -4208,16 +4208,16 @@ Copyright (C) Microsoft Corporation. All rights reserved. - <_ClickOnceRuntimeCopyLocalItems Include="@(RuntimeTargetsCopyLocalItems)" Condition="'%(RuntimeTargetsCopyLocalItems.CopyLocal)' == 'true'" /> - <_ClickOnceRuntimeCopyLocalItems Include="@(NativeCopyLocalItems)" + <_ClickOnceRuntimeCopyLocalItems Include="@(NativeCopyLocalItems)" Condition="'%(NativeCopyLocalItems.CopyLocal)' == 'true'" /> <_ClickOnceRuntimeCopyLocalItems Remove="@(_DeploymentReferencePaths)" /> <_ClickOnceFiles Include="@(ContentWithTargetPath);@(_DeploymentManifestIconFile);@(AppConfigWithTargetPath);@(NetCoreRuntimeJsonFilesForClickOnce);@(_ClickOnceRuntimeCopyLocalItems)"/> diff --git a/src/Tasks/Microsoft.Common.overridetasks b/src/Tasks/Microsoft.Common.overridetasks index 730d63c037c..ef646c53633 100644 --- a/src/Tasks/Microsoft.Common.overridetasks +++ b/src/Tasks/Microsoft.Common.overridetasks @@ -1,8 +1,8 @@  - - + diff --git a/src/Tasks/Microsoft.Common.props b/src/Tasks/Microsoft.Common.props index 942daa68814..b2ab2971004 100644 --- a/src/Tasks/Microsoft.Common.props +++ b/src/Tasks/Microsoft.Common.props @@ -19,7 +19,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true - @@ -31,10 +31,10 @@ Copyright (C) Microsoft Corporation. All rights reserved. - @@ -59,12 +59,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. - - 11.0 10.0 - $(MSBuildExtensionsPath)\v4.0\Custom.Before.$(MSBuildThisFile) @@ -110,7 +110,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. @@ -119,15 +119,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildExtensionsPath)\v$(MSBuildToolsVersion)\Custom.After.$(MSBuildThisFile) - - @@ -146,15 +146,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. - - @@ -163,7 +163,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. - diff --git a/src/Tasks/Microsoft.Common.targets b/src/Tasks/Microsoft.Common.targets index b3e9be1fa09..0c7501abd00 100644 --- a/src/Tasks/Microsoft.Common.targets +++ b/src/Tasks/Microsoft.Common.targets @@ -15,18 +15,18 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> - @@ -43,13 +43,13 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(ImportByWildcardBeforeMicrosoftCommonTargets) true @@ -73,15 +73,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(ImportByWildcardBeforeMicrosoftNetFrameworkProps) true @@ -104,7 +104,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + @@ -116,7 +116,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. @@ -130,7 +130,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true - @@ -145,15 +145,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + - $(MSBuildFrameworkToolsPath) diff --git a/src/Tasks/Microsoft.Common.tasks b/src/Tasks/Microsoft.Common.tasks index a1eb793d5ee..f50a18f2fe7 100644 --- a/src/Tasks/Microsoft.Common.tasks +++ b/src/Tasks/Microsoft.Common.tasks @@ -1,6 +1,6 @@  - + @@ -110,7 +110,7 @@ - + @@ -182,4 +182,3 @@ - diff --git a/src/Tasks/Microsoft.Data.Entity.targets b/src/Tasks/Microsoft.Data.Entity.targets index 4052db0deb8..db087b719f1 100644 --- a/src/Tasks/Microsoft.Data.Entity.targets +++ b/src/Tasks/Microsoft.Data.Entity.targets @@ -1,12 +1,12 @@  - diff --git a/src/Tasks/Microsoft.NET.props b/src/Tasks/Microsoft.NET.props index 6c3062ab1e5..12ee616dbce 100644 --- a/src/Tasks/Microsoft.NET.props +++ b/src/Tasks/Microsoft.NET.props @@ -29,7 +29,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. diff --git a/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets b/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets index e39ebb16d75..8c86bcf4a87 100644 --- a/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets +++ b/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets @@ -24,12 +24,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + - @@ -82,7 +82,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. GetReferenceAssemblyPaths - + @@ -128,7 +128,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + diff --git a/src/Tasks/Microsoft.NETFramework.props b/src/Tasks/Microsoft.NETFramework.props index d33d74e017b..5d9f646cd4c 100644 --- a/src/Tasks/Microsoft.NETFramework.props +++ b/src/Tasks/Microsoft.NETFramework.props @@ -14,18 +14,18 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> - diff --git a/src/Tasks/Microsoft.NETFramework.targets b/src/Tasks/Microsoft.NETFramework.targets index 83a06860838..bd1d3ce2e19 100644 --- a/src/Tasks/Microsoft.NETFramework.targets +++ b/src/Tasks/Microsoft.NETFramework.targets @@ -14,18 +14,18 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> - @@ -43,8 +43,8 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(ImportByWildcardBeforeMicrosoftNetFrameworkTargets) true @@ -67,13 +67,13 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + - + diff --git a/src/Tasks/Microsoft.ServiceModel.targets b/src/Tasks/Microsoft.ServiceModel.targets index 2a443dbb90b..7204d546177 100644 --- a/src/Tasks/Microsoft.ServiceModel.targets +++ b/src/Tasks/Microsoft.ServiceModel.targets @@ -1,12 +1,12 @@  - diff --git a/src/Tasks/Microsoft.VisualBasic.CurrentVersion.targets b/src/Tasks/Microsoft.VisualBasic.CurrentVersion.targets index 5bb53d681e2..84efede9a47 100644 --- a/src/Tasks/Microsoft.VisualBasic.CurrentVersion.targets +++ b/src/Tasks/Microsoft.VisualBasic.CurrentVersion.targets @@ -8,7 +8,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and This file defines the steps in the standard build process specific for VB .NET projects. For example, it contains the step that actually calls the VB compiler. The remainder -of the build process is defined in Microsoft.Common.targets, which is imported by +of the build process is defined in Microsoft.Common.targets, which is imported by this file. Copyright (C) Microsoft Corporation. All rights reserved. @@ -21,7 +21,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true true true - true + true @@ -65,14 +65,14 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + <_Temporary Remove="@(_Temporary)" /> - + <_NoWarnings Condition=" '$(WarningLevel)' == '0' ">true <_NoWarnings Condition=" '$(WarningLevel)' == '1' ">false - - + + $(IntermediateOutputPath)$(TargetName).compile.pdb @@ -227,7 +227,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + @@ -272,7 +272,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. OptionExplicit="$(OptionExplicit)" OptionInfer="$(OptionInfer)" OptionStrict="$(OptionStrict)" - OptionStrictType="$(OptionStrictType)" + OptionStrictType="$(OptionStrictType)" OutputAssembly="@(XamlIntermediateAssembly)" Platform="$(PlatformTarget)" Prefer32Bit="$(Prefer32Bit)" @@ -308,12 +308,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + <_CoreCompileResourceInputs Remove="@(_CoreCompileResourceInputs)" /> + + + + --> + diff --git a/src/Tasks/Microsoft.VisualBasic.targets b/src/Tasks/Microsoft.VisualBasic.targets index 3e597e1f304..86e813513f2 100644 --- a/src/Tasks/Microsoft.VisualBasic.targets +++ b/src/Tasks/Microsoft.VisualBasic.targets @@ -9,7 +9,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and This file defines the steps in the standard build process specific for VB .NET projects. For example, it contains the step that actually calls the VB compiler. The remainder -of the build process is defined in Microsoft.Common.targets, which is imported by +of the build process is defined in Microsoft.Common.targets, which is imported by this file. Copyright (C) Microsoft Corporation. All rights reserved. @@ -18,17 +18,17 @@ Copyright (C) Microsoft Corporation. All rights reserved. @@ -36,7 +36,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildFrameworkToolsPath)\Microsoft.VisualBasic.targets - $(MsBuildFrameworkToolsPath) @@ -54,14 +54,14 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(ImportByWildcardBeforeMicrosoftCommonTargets) true @@ -106,15 +106,15 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(ImportByWildcardBeforeMicrosoftNetFrameworkProps) true @@ -137,24 +137,24 @@ Copyright (C) Microsoft Corporation. All rights reserved. - + - + targets), we're stuck doing it this way instead. --> - + - + targets), and Microsoft.Common.targets does likewise with Microsoft.NETFramework.props, we're stuck doing it this + way instead. --> - + @@ -164,29 +164,29 @@ Copyright (C) Microsoft Corporation. All rights reserved. + targets), and Microsoft.Common.targets does likewise with Microsoft.NETFramework.props, we're stuck doing it this + way instead. --> - + - + targets), we're stuck doing it this way instead. --> - + - + - $(MSBuildFrameworkToolsPath) diff --git a/src/Tasks/Microsoft.WinFx.targets b/src/Tasks/Microsoft.WinFx.targets index d42da660988..a064330ac82 100644 --- a/src/Tasks/Microsoft.WinFx.targets +++ b/src/Tasks/Microsoft.WinFx.targets @@ -1,12 +1,12 @@  - diff --git a/src/Tasks/Microsoft.WorkflowBuildExtensions.targets b/src/Tasks/Microsoft.WorkflowBuildExtensions.targets index b2f1480fadc..fe997dc7382 100644 --- a/src/Tasks/Microsoft.WorkflowBuildExtensions.targets +++ b/src/Tasks/Microsoft.WorkflowBuildExtensions.targets @@ -12,14 +12,14 @@ Copyright (C) Microsoft Corporation. All rights reserved. - diff --git a/src/Tasks/Microsoft.Xaml.targets b/src/Tasks/Microsoft.Xaml.targets index 70a1c2079eb..6eb77004e77 100644 --- a/src/Tasks/Microsoft.Xaml.targets +++ b/src/Tasks/Microsoft.Xaml.targets @@ -1,17 +1,17 @@  - - + to the correct .NET Framework location. --> $(MSBuildToolsPath64) diff --git a/src/Tasks/Workflow.VisualBasic.targets b/src/Tasks/Workflow.VisualBasic.targets index 9e13597f2c3..7e24548e73a 100644 --- a/src/Tasks/Workflow.VisualBasic.targets +++ b/src/Tasks/Workflow.VisualBasic.targets @@ -1,14 +1,14 @@  - - \ No newline at end of file + diff --git a/src/Tasks/Workflow.targets b/src/Tasks/Workflow.targets index 03a86174d6d..065fab17c44 100644 --- a/src/Tasks/Workflow.targets +++ b/src/Tasks/Workflow.targets @@ -1,14 +1,14 @@  - - \ No newline at end of file + From a4f64e8f07a090108c64ac43439d0c4fbb618451 Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Fri, 3 Apr 2020 18:55:16 +0530 Subject: [PATCH 2/2] Add/Remove NewLine(s) where necessary only in MSBuild Common props, targets and tasks files Add New Line(s) between every block to make it clear. Remove unnecessary New Line(s) to reduce scrolling. --- .../Microsoft.CSharp.CrossTargeting.targets | 1 + .../Microsoft.CSharp.CurrentVersion.targets | 17 +-- src/Tasks/Microsoft.CSharp.targets | 3 +- .../Microsoft.Common.CrossTargeting.targets | 7 +- .../Microsoft.Common.CurrentVersion.targets | 122 +++++++++--------- src/Tasks/Microsoft.Common.overridetasks | 9 ++ src/Tasks/Microsoft.Common.props | 3 + src/Tasks/Microsoft.Common.targets | 2 + src/Tasks/Microsoft.Common.tasks | 2 + src/Tasks/Microsoft.Data.Entity.targets | 1 + src/Tasks/Microsoft.Managed.Before.targets | 1 + ...icrosoft.NETFramework.CurrentVersion.props | 8 -- ...rosoft.NETFramework.CurrentVersion.targets | 6 +- src/Tasks/Microsoft.NETFramework.props | 1 + src/Tasks/Microsoft.NETFramework.targets | 1 + src/Tasks/Microsoft.ServiceModel.targets | 1 + ...crosoft.VisualBasic.CrossTargeting.targets | 1 + ...crosoft.VisualBasic.CurrentVersion.targets | 16 +-- src/Tasks/Microsoft.VisualBasic.targets | 3 +- src/Tasks/Microsoft.WinFx.targets | 1 + .../Microsoft.WorkflowBuildExtensions.targets | 1 + src/Tasks/Microsoft.Xaml.targets | 1 + src/Tasks/Workflow.VisualBasic.targets | 1 + src/Tasks/Workflow.targets | 1 + 24 files changed, 109 insertions(+), 101 deletions(-) diff --git a/src/Tasks/Microsoft.CSharp.CrossTargeting.targets b/src/Tasks/Microsoft.CSharp.CrossTargeting.targets index 68d1aa0797a..26ae23579d9 100644 --- a/src/Tasks/Microsoft.CSharp.CrossTargeting.targets +++ b/src/Tasks/Microsoft.CSharp.CrossTargeting.targets @@ -17,6 +17,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed\Microsoft.CSharp.DesignTime.targets + diff --git a/src/Tasks/Microsoft.CSharp.CurrentVersion.targets b/src/Tasks/Microsoft.CSharp.CurrentVersion.targets index 6b433c425c9..f5955642de1 100644 --- a/src/Tasks/Microsoft.CSharp.CurrentVersion.targets +++ b/src/Tasks/Microsoft.CSharp.CurrentVersion.targets @@ -83,15 +83,16 @@ Copyright (C) Microsoft Corporation. All rights reserved. For other project systems, this transformation may be different. --> + + - <_Temporary Remove="@(_Temporary)" /> @@ -102,9 +103,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. RootNamespace="$(RootNamespace)" UseDependentUponConvention="$(EmbeddedResourceUseDependentUponConvention)" Condition="'%(EmbeddedResource.ManifestResourceName)' == '' and ('%(EmbeddedResource.WithCulture)' == 'false' or '%(EmbeddedResource.Type)' == 'Resx')"> - - @@ -114,9 +113,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. PrependCultureAsDirectory="false" UseDependentUponConvention="$(EmbeddedResourceUseDependentUponConvention)" Condition="'%(EmbeddedResource.ManifestResourceName)' == '' and '%(EmbeddedResource.WithCulture)' == 'true' and '%(EmbeddedResource.Type)' == 'Non-Resx'"> - - @@ -124,23 +121,18 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_Temporary Remove="@(_Temporary)" /> - - - - - @@ -328,9 +320,11 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed\Microsoft.CSharp.DesignTime.targets + + @@ -346,7 +340,6 @@ using System.Reflection%3b true - true - true - $([System.Globalization.CultureInfo]::CurrentUICulture.Name) diff --git a/src/Tasks/Microsoft.CSharp.targets b/src/Tasks/Microsoft.CSharp.targets index 73cfe2c94b5..80361f7c441 100644 --- a/src/Tasks/Microsoft.CSharp.targets +++ b/src/Tasks/Microsoft.CSharp.targets @@ -16,6 +16,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> + $(MsBuildFrameworkToolsPath) @@ -191,4 +191,5 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildFrameworkToolsPath) + diff --git a/src/Tasks/Microsoft.Common.CrossTargeting.targets b/src/Tasks/Microsoft.Common.CrossTargeting.targets index 3b3e8a1d191..c4bc9a95d34 100644 --- a/src/Tasks/Microsoft.Common.CrossTargeting.targets +++ b/src/Tasks/Microsoft.Common.CrossTargeting.targets @@ -11,10 +11,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> + true true + @@ -40,14 +42,13 @@ Copyright (C) Microsoft Corporation. All rights reserved. @(_TargetFrameworkInfo->'%(TargetFrameworkMonikers)') @(_TargetFrameworkInfo->'%(TargetPlatformMonikers)') $(_AdditionalPropertiesFromProject) - false - false true + @@ -178,6 +179,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true + @@ -217,4 +219,5 @@ Copyright (C) Microsoft Corporation. All rights reserved. + diff --git a/src/Tasks/Microsoft.Common.CurrentVersion.targets b/src/Tasks/Microsoft.Common.CurrentVersion.targets index 16ef51e2538..49f81435b5e 100644 --- a/src/Tasks/Microsoft.Common.CurrentVersion.targets +++ b/src/Tasks/Microsoft.Common.CurrentVersion.targets @@ -30,7 +30,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. - 10.0 @@ -163,7 +162,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. - $(TargetType) library @@ -221,7 +219,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. - true @@ -362,10 +359,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. true + true false + $(MSBuildProjectFile).FileListAbsolute.txt @@ -382,6 +381,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_GenerateBindingRedirectsIntermediateAppConfig>$(IntermediateOutputPath)$(TargetFileName).config + @@ -522,7 +522,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(PROCESSOR_ARCHITECTURE) - @@ -924,6 +923,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. PostBuildEvent + @@ -941,7 +941,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. ============================================================ --> - <_ProjectDefaultTargets Condition="'$(MSBuildProjectDefaultTargets)' != ''">$(MSBuildProjectDefaultTargets) <_ProjectDefaultTargets Condition="'$(MSBuildProjectDefaultTargets)' == ''">Build @@ -1086,6 +1085,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. + @@ -1096,9 +1096,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. - - - @@ -1280,6 +1277,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. ============================================================ --> + @@ -1304,7 +1302,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_Temp Remove="@(_Temp)" /> - @@ -1317,7 +1314,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_Temp Remove="@(_Temp)" /> - @@ -1341,6 +1337,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_Temp Remove="@(_Temp)" /> + false true + + false @@ -2650,6 +2641,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. + <_ReferencesFromRAR Include="@(ReferencePath->WithMetadataValue('ReferenceSourceTarget', 'ResolveAssemblyReference'))"/> + @@ -2687,7 +2680,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. [IN] @(DesignTimeReference) - List of assembly references as simple/fusion names. - [OUT] @(ReferencePath) - Paths to resolved primary files. @@ -2778,6 +2770,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. + @@ -3075,6 +3070,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. + @@ -3093,6 +3089,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. true false + @@ -3255,6 +3252,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. + - - - - + + <_DeploymentPublishFileOfTypeManifestEntryPoint Include="@(PublishFile)" Condition="'%(FileType)'=='ManifestEntryPoint'"/> @@ -3915,10 +3909,9 @@ Copyright (C) Microsoft Corporation. All rights reserved. SigningManifests="$(SignManifests)" DeploymentManifestEntryPoint="@(ApplicationManifest)" PublishFiles="@(_DeploymentPublishFileOfTypeManifestEntryPoint)"> - - + <_DeploymentManifestEntryPoint Include="@(_DeploymentManifestLauncherEntryPoint)"/> + + + + + + + + + + diff --git a/src/Tasks/Microsoft.Common.props b/src/Tasks/Microsoft.Common.props index b2ab2971004..eaa9725f75e 100644 --- a/src/Tasks/Microsoft.Common.props +++ b/src/Tasks/Microsoft.Common.props @@ -11,6 +11,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> + true true @@ -171,6 +172,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildToolsPath32)\..\..\..\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.props $(MSBuildToolsPath)\NuGet.props + @@ -188,4 +190,5 @@ Copyright (C) Microsoft Corporation. All rights reserved. true true + diff --git a/src/Tasks/Microsoft.Common.targets b/src/Tasks/Microsoft.Common.targets index 0c7501abd00..f14a2810499 100644 --- a/src/Tasks/Microsoft.Common.targets +++ b/src/Tasks/Microsoft.Common.targets @@ -15,6 +15,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> + + true - $(TargetFrameworkSubset) - @@ -41,7 +39,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. - true @@ -79,17 +75,13 @@ Copyright (C) Microsoft Corporation. All rights reserved. true - $(MSBuildFrameworkToolsRoot)\v3.5 - $(SDK35ToolsPath) - v2.0.50727 v$(MSBuildRuntimeVersion) - diff --git a/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets b/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets index 8c86bcf4a87..5e79387e8cd 100644 --- a/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets +++ b/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets @@ -58,7 +58,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_CombinedTargetFrameworkDirectoriesItem Condition=" '@(_CombinedTargetFrameworkDirectoriesItem)' == ''" Include="@(_TargetedFrameworkDirectoryItem)" /> - @@ -69,6 +68,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_TargetFrameworkSDKDirectoryItem Include="$(TargetFrameworkSDKDirectory)"/> + @@ -89,7 +89,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_HasReferenceToSystemRuntime Condition="'$(DependsOnSystemRuntime)' == 'true'">true - <_HasReferenceToSystemRuntime Condition="'%(_ResolvedProjectReferencePaths.TargetPlatformIdentifier)' == 'Portable'">true <_HasReferenceToSystemRuntime Condition="'%(_ResolvedProjectReferencePaths.TargetFrameworkIdentifier)' == '.NETStandard' and '%(_ResolvedProjectReferencePaths.TargetFrameworkVersion)' < '2.0'">true @@ -100,10 +99,12 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_DesignTimeFacadeAssemblies Include="%(DesignTimeFacadeDirectories.Identity)*.dll"/> + <_DesignTimeFacadeAssemblies Include="%(DesignTimeFacadeDirectories.Identity)netstandard.dll" Condition="Exists('%(DesignTimeFacadeDirectories.Identity)netstandard.dll')"/> + <_DesignTimeFacadeAssemblies_Names Include="@(_DesignTimeFacadeAssemblies->'%(FileName)')"> %(_DesignTimeFacadeAssemblies.Identity) @@ -120,6 +121,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. false ImplicitlyExpandDesignTimeFacades + <_ResolveAssemblyReferenceResolvedFiles Include="@(ReferencePath)" Condition="'%(ReferencePath.ResolvedFrom)' == 'ImplicitlyExpandDesignTimeFacades'" /> diff --git a/src/Tasks/Microsoft.NETFramework.props b/src/Tasks/Microsoft.NETFramework.props index 5d9f646cd4c..ed2109fb069 100644 --- a/src/Tasks/Microsoft.NETFramework.props +++ b/src/Tasks/Microsoft.NETFramework.props @@ -14,6 +14,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> + + + + - <_Temporary Remove="@(_Temporary)" /> @@ -102,9 +103,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. RootNamespace="$(RootNamespace)" UseDependentUponConvention="$(EmbeddedResourceUseDependentUponConvention)" Condition="'%(EmbeddedResource.ManifestResourceName)' == '' and ('%(EmbeddedResource.WithCulture)' == 'false' or '%(EmbeddedResource.Type)' == 'Resx')"> - - @@ -114,9 +113,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. PrependCultureAsDirectory="false" UseDependentUponConvention="$(EmbeddedResourceUseDependentUponConvention)" Condition="'%(EmbeddedResource.ManifestResourceName)' == '' and '%(EmbeddedResource.WithCulture)' == 'true' and '%(EmbeddedResource.Type)' == 'Non-Resx'"> - - @@ -124,23 +121,18 @@ Copyright (C) Microsoft Corporation. All rights reserved. <_Temporary Remove="@(_Temporary)" /> - - - - - @@ -328,9 +320,11 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildExtensionsPath)\Microsoft\VisualStudio\Managed\Microsoft.VisualBasic.DesignTime.targets + + @@ -350,7 +344,6 @@ Copyright (C) Microsoft Corporation. All rights reserved. true - true - $([System.Globalization.CultureInfo]::CurrentUICulture.Name) diff --git a/src/Tasks/Microsoft.VisualBasic.targets b/src/Tasks/Microsoft.VisualBasic.targets index 86e813513f2..9e3824ca1b2 100644 --- a/src/Tasks/Microsoft.VisualBasic.targets +++ b/src/Tasks/Microsoft.VisualBasic.targets @@ -17,6 +17,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. --> + $(MsBuildFrameworkToolsPath) @@ -191,4 +191,5 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(MSBuildFrameworkToolsPath) + diff --git a/src/Tasks/Microsoft.WinFx.targets b/src/Tasks/Microsoft.WinFx.targets index a064330ac82..4cf77fc6f3c 100644 --- a/src/Tasks/Microsoft.WinFx.targets +++ b/src/Tasks/Microsoft.WinFx.targets @@ -1,4 +1,5 @@  + + diff --git a/src/Tasks/Microsoft.Xaml.targets b/src/Tasks/Microsoft.Xaml.targets index 6eb77004e77..78f4055b273 100644 --- a/src/Tasks/Microsoft.Xaml.targets +++ b/src/Tasks/Microsoft.Xaml.targets @@ -1,4 +1,5 @@  +