New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Expander.TryExecuteWellKnownFunction #9975

Open

YuliiaKovalova opened this issue Apr 4, 2024 · 0 comments

Assignees

Labels

needs-triage Priority:3

Member

YuliiaKovalova commented Apr 4, 2024 •

edited

Refactor candidate

I have stumbled upon the piece of code and suggest to rethink it:

msbuild/src/Build/Evaluation/Expander.cs

Line 3643 in 28f488a

    
           private bool TryExecuteWellKnownFunction(out object returnVal, object objectInstance, object[] args)

It contains code duplications and it's current size poorly manageable.

YuliiaKovalova added the Priority:3 label

YuliiaKovalova self-assigned this

YuliiaKovalova added the needs-triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment