Null annotate ILogger.cs #9876
Merged
Null annotate ILogger.cs #9876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ILogger.Parameters` is documented as allowing a `null` value. This change updates the annotation accordingly. NOTE this change has been made in the browser without building, so it's possible that CI highlights other usages that need fixing.
AR-May
approved these changes
Mar 25, 2024
rainersigwald
approved these changes
Mar 26, 2024
rainersigwald
added a commit
to dotnet/sdk
that referenced
this pull request
May 1, 2024
rainersigwald
added a commit
to rainersigwald/sdk
that referenced
this pull request
May 1, 2024
|
So this was a breaking change that required reaction in SDK. I think we might need to revert it? @dotnet/kitten |
|
How was this breaking? I can't see anything in the cross referenced PR. |
|
It can break third-party loggers in the same way it broke the two null-annotated loggers in the MSBuild codebase, by requiring them to add a |
|
I think I would consider this an acceptable source breaking change. Core libraries do this as well, for example https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/nullable-ref-type-annotation-changes. |
|
They do, with explicit breaking change docs, once a year. I agree it's a good change, just not sure what our pain/benefit policy is there. |
v-wuzhai
pushed a commit
to dotnet/sdk
that referenced
this pull request
May 6, 2024
Forgind
pushed a commit
to Forgind/sdk
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILogger.Parametersis documented as allowing anullvalue. This change updates the annotation accordingly.CPS explicitly returns null from its implementation of this interface.