Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of SDK resolvers should be immutable in a given process #9679

Closed
rainersigwald opened this issue Jan 24, 2024 · 0 comments · Fixed by #9777
Closed

List of SDK resolvers should be immutable in a given process #9679

rainersigwald opened this issue Jan 24, 2024 · 0 comments · Fixed by #9777
Assignees
@AR-May
Labels
performance Performance-Scenario-General This issue affects performance in general. size:3 triaged
Milestone
VS 17.10

Comments

@rainersigwald
Copy link
Member

It's not the primary cause of the wasted time in #9678, but it's surprising that MSBuild ever attempts to rediscover and reload SDK resolvers. Since the manifests are in one of the treat-as-immutable-for-the-process-lifetime cones, we should identify resolvers at most once in a process lifetime.
@rainersigwald rainersigwald added performance Performance-Scenario-General This issue affects performance in general. labels Jan 24, 2024
@rainersigwald rainersigwald added this to the VS 17.10 milestone Jan 24, 2024
@AR-May AR-May self-assigned this Jan 30, 2024
This was referenced Feb 19, 2024
Closed
Merged
AR-May added a commit that referenced this issue Mar 1, 2024
@AR-May @rokonec
Fix events for sdk resolvers load (#9777)
0032522 
Fixes #9679

Context
It seems like events in sdk resolver service are misleading. We emit some events even when resolvers were taken from process-wide cache and not actually loaded.

Changes Made
Moved the events emission to SdkResolverLoader, so that the events concerning loading are not emitted when a cached value was used.

Co-authored-by: Roman Konecny <rokonecn@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AR-May AR-May

Labels
performance Performance-Scenario-General This issue affects performance in general. size:3 triaged
Projects
None yet
Milestone
VS 17.10
2 participants
@rainersigwald @AR-May