Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETSDKE2E][Loc]With NET9 SDK installed in loc OS(Chinese), Unit of time in message is missing when creating project in CLI. #9601

Open
vdanche opened this issue Jan 4, 2024 · 11 comments
Assignees
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. bug Localization triaged

Comments

@vdanche
Copy link
Member

vdanche commented Jan 4, 2024

  1. Install 9.0.100-alpha.1.24053.14 in Loc OS(e.g Chinese OS)
  2. Run "dotnet new console" in CLI.
  3. Check if the messages are localized well.

Expected Result:
the messages are localized well.

Actual Result:
Unit of time in message is missing.

Chinese(Repro)
image

EN:
image

German(not repro)
image

C:\Users\v-danche>dotnet --info
.NET SDK:
Version: 9.0.100-alpha.1.24053.14
Commit: 48543d2076
Workload version: 9.0.100-manifests.b3326be0

运行时环境:
OS Name: Windows
OS Version: 10.0.22621
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\9.0.100-alpha.1.24053.14\

已安装 .NET 工作负载:
没有要显示的已安装工作负载。

Host:
Version: 9.0.0-alpha.1.24053.1
Architecture: x64
Commit: cc26196708

.NET SDKs installed:
9.0.100-alpha.1.24053.14 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 9.0.0-alpha.1.23620.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 9.0.0-alpha.1.24053.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 9.0.0-alpha.1.24053.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
None

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@marcpopMSFT marcpopMSFT transferred this issue from dotnet/sdk Jan 4, 2024
@marcpopMSFT marcpopMSFT added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Jan 4, 2024
@marcpopMSFT
Copy link
Member

This appears to be the new terminal logger output so routing to msbuild and marking it for TL tracking.

@rainersigwald rainersigwald added Localization needs-triage Have yet to determine what bucket this goes in. and removed untriaged labels Jan 4, 2024
@baronfel baronfel added the bug label Jan 8, 2024
@vdanche
Copy link
Member Author

vdanche commented Feb 2, 2024

we checked on today's build 9.0.100-preview.1.24101.4 SDK on Chinese OS.
the time unit is added for log output after running "dotnet new console"
image

But the time unit is still missing after running "dotnet build"
image

@AR-May
Copy link
Member

AR-May commented Mar 14, 2024

It should be already fixed with the fix of this issue: https://ceapex.visualstudio.com/CEINTL/_workitems/edit/935605

@AR-May AR-May closed this as completed Mar 14, 2024
@vdanche
Copy link
Member Author

vdanche commented Mar 19, 2024

@AR-May It still happen when building project on Chinese OS on 9.0.100-preview.3.24165.20(runtime-9.0.0-preview.3.24162.31), Do we need to file a new bug for it?
image

EN:
image

@AR-May
Copy link
Member

AR-May commented Mar 19, 2024

It seems like not everything was indeed fixed by the issue that I mentioned. I will reopen this issue, no need to create new one.

@AR-May
Copy link
Member

AR-May commented Mar 19, 2024

Team triage: @JaynieBai Could you please fill a localization bug like the one I mentioned above.

@AR-May AR-May added triaged and removed needs-triage Have yet to determine what bucket this goes in. labels Mar 19, 2024
@JaynieBai
Copy link
Member

Team triage: @JaynieBai Could you please fill a localization bug like the one I mentioned above.

Log bug https://ceapex.visualstudio.com/CEINTL/_workitems/edit/956251

@JaynieBai
Copy link
Member

Translated in localization PR #10003

@vdanche
Copy link
Member Author

vdanche commented Apr 25, 2024

@AR-May we checked on 9.0.100-preview.4.24224.4
Now, the unit of time can be displayed well after running "dotnet build"
image
But when we run "dotnet build -f net9.0", unit of time is still missing
image

EN
image

@AR-May AR-May reopened this Apr 25, 2024
@AR-May
Copy link
Member

AR-May commented Apr 25, 2024

When you set up the framework, it is a separate string indeed. And it is not translated well it seems.
@JaynieBai could you please open a loc bug for it too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. bug Localization triaged
Projects
None yet
Development

No branches or pull requests

6 participants