Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enumeration values for DebugType in XSD #6849

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Sep 15, 2021

Context

The DebugType property has a set of expected values, and is not just a plain text property.

Currently completion on the DebugType property offers no guidance:

image

Changes Made

This change adds those values so they appear in completion. It also documents that pdbonly is equivalent to full in recent compilers.

Testing

None.

Notes

None.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We're past localization freeze in our repo but not VS where this will actually be localized so we can take this for 17.0.

Can we get a quick look from someone on @dotnet/roslyn-compiler, since this is a C#/VB option?

@rainersigwald rainersigwald added the Area: IntelliSense Issues with the XSD-schema driven code completion experience for MSBuild in Visual Studio. label Sep 16, 2021
@drewnoakes
Copy link
Member Author

@rainersigwald I'll leave it to you good folks to determine when this should be merged. Thanks.

@rainersigwald
Copy link
Member

@drewnoakes The test failures look legitimate to me--they're in XSD validation. Can you take a look please?

@rainersigwald
Copy link
Member

This code has been commented out since time immemorial:

//ProjectSchemaValidationHandler.VerifyProjectSchema
// (
// projectFilename,
// msbuildTempXsdFilenames[0],
// @"c:\"
// );

But if it wasn't, you would have gotten this test error instead of "expected true" or whatever:

Message: 
    Microsoft.Build.CommandLine.InitializationException : C:\Users\raines\AppData\Local\Temp\4ghowcq5.bch\MSBuild\Microsoft.Build.CommonTypes.xsd(1255,6): Schema validation error : MSBUILD : MSB1046: The schema "C:\Users\raines\AppData\Local\Temp\4ghowcq5.bch\Microsoft.Build.xsd" is not valid. The type attribute cannot be present with either simpleType or complexType.

  Stack Trace: 
    InitializationException.Throw(String message, String invalidSwitch) line 186
    ProjectSchemaValidationHandler.ThrowInitializationExceptionWithResource(String projectFile, Int32 fileLine, Int32 fileEndLine, Int32 fileColumn, Int32 fileEndColumn, String resourceName, Object[] args) line 217
    ProjectSchemaValidationHandler.VerifyProjectSchema(String projectFile, String schemaFile) line 156
    ProjectSchemaValidationHandler.VerifyProjectSchema(String projectFile, String schemaFile, String binPath) line 67
    ProjectSchemaValidationHandlerTest.VerifyValidProjectSchema() line 187

@rainersigwald
Copy link
Member

Pushed a fix.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Sep 17, 2021
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
@AR-May AR-May merged commit a08f6bd into dotnet:main Sep 24, 2021
@drewnoakes drewnoakes deleted the debug-type-xsd branch October 6, 2021 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IntelliSense Issues with the XSD-schema driven code completion experience for MSBuild in Visual Studio. merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants