Remove depenency on MemberRef Parent of a custom attribute constructor being a TypeReference #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r being a TypeReference
|
To test, can you try overwriting your runtime SDK's copy of MSBuild with a just-built one following the docs here? https://github.com/dotnet/msbuild/blob/main/documentation/Deploy-MSBuild.md
|
|
@rainersigwald Thank you for the advice, with this fix, the issue is fixed. |
davidwrighton
requested review from
ladipro and
hoyosjs
and removed request for
hoyosjs
ladipro
added
the
merge-when-branch-open
rainersigwald
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6734
Also fixes #6730
This fixes #6734 in my scenario.