Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include globs that look like \subdir** do not include files without extensions #6708

Closed
ahmedalejo opened this issue Jul 24, 2021 · 2 comments
Labels
bug needs-triage Have yet to determine what bucket this goes in.

Comments

@ahmedalejo
Copy link

Issue Description

A regression introduced in Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET.
Related to @ForNeVeR in dotnet/sdk#17976. and @ladipro in #6502

Steps to Reproduce

Add a .well-known\apple-app-site-association file to the wwwroot folder of an aspnetcore project. Then run dotnet publish.

Expected Behavior

  • The .well-known\apple-app-site-association file should be published to the wwwroot folder.

Actual Behavior

  • The .well-known\apple-app-site-association file is not published to the wwwroot folder.

Analysis

This seems to be related to files without an extension like apple-app-site-association rendering the .weel-known folder to be considered empty and therefore not published.
This worked previously with Microsoft (R) Build Engine version 16.10.1+2fd48ab73.

Works when the following is added

<Content Include="wwwroot\.well-known\**" CopyToPublishDirectory="Always" />

but not

<Content Include="wwwroot\.well-known\**" />

Note that none of the above was required in the previous version (Microsoft (R) Build Engine version 16.10.1+2fd48ab73)

Versions & Configurations

on Azure DevOps agent.

  • Microsoft (R) Build Engine version 16.10.1+2fd48ab73 for .NET publish includes wwwroot/.well-known folder
  • Microsoft (R) Build Engine version 16.10.2+857e5a733 for .NET publish does not includes wwwroot/.well-known folder
@ahmedalejo ahmedalejo added bug needs-triage Have yet to determine what bucket this goes in. labels Jul 24, 2021
@ladipro
Copy link
Member

ladipro commented Jul 29, 2021

The previous behavior where the file was included in Content was unfortunately a bug. Content by default excludes everything from directories with a leading . (dot). Directories with such names are considered internal / hidden, take .git as an example.

#6531 is the fix that got us back to the correct behavior.

@benvillalobos
Copy link
Member

Team Triage: Closing this out since there is a fix out. Feel free to comment & reopen if, after updating, you're still seeing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage Have yet to determine what bucket this goes in.
Projects
None yet
Development

No branches or pull requests

3 participants