Add up-to-date ETW for WriteLinesToFile #6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Framework/MSBuildEventSource.cs
Outdated
| } | ||
|
|
||
| [Event(61, Keywords = Keywords.All)] | ||
| public void WriteLinesToFileUpToDateStop(string fileItemSpec) |
There was a problem hiding this comment.
Suggested change
| public void WriteLinesToFileUpToDateStop(string fileItemSpec) | |
| public void WriteLinesToFileUpToDateStop(string fileItemSpec, bool wasUpToDate) |
src/Tasks/FileIO/WriteLinesToFile.cs
Outdated
| { | ||
| Log.LogMessageFromResources(MessageImportance.Low, "WriteLinesToFile.ErrorReadingFile", File.ItemSpec); | ||
| } | ||
| MSBuildEventSource.Log.WriteLinesToFileUpToDateStop(File.ItemSpec); |
There was a problem hiding this comment.
Suggested change
| MSBuildEventSource.Log.WriteLinesToFileUpToDateStop(File.ItemSpec); | |
| MSBuildEventSource.Log.WriteLinesToFileUpToDateStop(File.ItemSpec, false); |
rainersigwald
approved these changes
Aug 9, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked through a trace of which tasks ran even for the second identical build. Many didn't have a "taskName," that is, _taskNode or _taskNode.Name was null, which surprised me. Of the rest, none in the MSBuild repo had up-to-date check behavior, as far as I could tell, except this one, so I added a check here. If I am correct, this finishes #6658