Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify project info in affinity missmatch error #6640

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Specify project info in affinity missmatch error #6640

merged 2 commits into from
Aug 11, 2021

Conversation

cdmihai
Copy link
Contributor

@cdmihai cdmihai commented Jun 30, 2021

Improves an obscure error message. Cherry-picked this commit out of #6635 because 16.11 loc window is closed.

@cdmihai
Copy link
Contributor Author

cdmihai commented Jun 30, 2021 •
edited

Seems to be depending on a new ErrorUtilies method introduced in #6569. Let's just wait until that PR gets into 16.11 and 16.11 merges back into main.

Forgind
Forgind approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds basically reasonable. I don't fully understand the error, but I assume this is right.

src/Build/BackEnd/Components/Scheduler/Scheduler.cs Outdated Show resolved Hide resolved
src/Build/BackEnd/Components/Scheduler/Scheduler.cs Show resolved Hide resolved
@dotnet dotnet deleted a comment from azure-pipelines bot Aug 3, 2021
@Forgind Forgind removed the blocked label Aug 5, 2021
@Forgind
Copy link
Member

Forgind commented Aug 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Aug 9, 2021
@rokonec rokonec merged commit b9424d9 into dotnet:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdmihai @Forgind @rokonec