Use extension in Next-to-MSBuild fallback #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea behind the fallback was that we'd load an assembly that matched (by simple name) from the MSBuild directory if there wasn't a match in the task/plugin folder. But assemblies aren't in the MSBuild folder (or anywhere on disk) by simple name: they have an extension. So this was never working. That was mostly irrelevant, because the assemblies that are 'next to MSBuild' in the .NET SDK are in MSBuild.deps.json as assembled in the SDK repo. But in our own bootstrap build, that's not the case and the normal fallback matters.
|
This brings up a question: if we've accidentally not been doing this fallback for . . . ever, should we just remove it? @brianrob might have thoughts related to dotnet/sdk#15558. |
This was referenced Jun 14, 2021
rainersigwald
added a commit
that referenced
this pull request
Jun 17, 2021
Normally DependencyModel is resolvable in dotnet build scenarios because it is in the SDK folder next to MSBuild. However, in our bootstrap MSBuild, that wasn't the case. Grab that file from the SDK that we're using to build and drop it next to the SDK task assemblies (not next to MSBuild, because of #6558).
rainersigwald
changed the title
To be clear on this issue, I think this isn't true and this PR will fix #5073. |
ladipro
approved these changes
Jul 12, 2021
rainersigwald
added
the
merge-when-branch-open
benvillalobos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind the fallback was that we'd load an assembly
that matched (by simple name) from the MSBuild directory if
there wasn't a match in the task/plugin folder. But
assemblies aren't in the MSBuild folder (or anywhere on disk)
by simple name: they have an extension. So this was never
working.
That was mostly irrelevant, because the assemblies that are
'next to MSBuild' in the .NET SDK are in MSBuild.deps.json
as assembled in the SDK repo. But in our own bootstrap build,
that's not the case and the normal fallback matters.