Add [Serializable] to PortableLibraryFiles and other similar classes #6490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
May 27, 2021
| @@ -10,6 +11,7 @@ namespace Microsoft.Build.Tasks | |||
| /// <remarks> | |||
| /// This class is a caching mechanism for the Register/UnregisterAssembly task to keep track of registered assemblies to clean up | |||
| /// </remarks> | |||
| [Serializable] | |||
There was a problem hiding this comment.
Comment why these are necessary?
benvillalobos
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke an internal test (see https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/326484).
I tested reverting the PR that removed the [Serializable] attributes as well as just adding them back in parallel. Both PRs worked:
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/327003
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/327004
So I would suggest just taking the smaller change to unblock master without creating unnecessary future changes.
/cc: @rainersigwald @benvillalobos